[PATCH] amd: amdgpu: fix coding style issue

Jingyu Wang posted 1 patch 3 years, 7 months ago
drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
[PATCH] amd: amdgpu: fix coding style issue
Posted by Jingyu Wang 3 years, 7 months ago
This is a patch to the amdgpu_sync.c file that fixes some warnings found by the checkpatch.pl tool

Signed-off-by: Jingyu Wang <jingyuwang_vip@163.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
index 504af1b93bfa..dfc787b749b2 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
@@ -1,5 +1,6 @@
-/*
- * Copyright 2014 Advanced Micro Devices, Inc.
+// SPDX-License-Identifier: GPL-2.0
+
+/* Copyright 2014 Advanced Micro Devices, Inc.
  * All Rights Reserved.
  *
  * Permission is hereby granted, free of charge, to any person obtaining a
@@ -315,6 +316,7 @@ struct dma_fence *amdgpu_sync_get_fence(struct amdgpu_sync *sync)
 	struct hlist_node *tmp;
 	struct dma_fence *f;
 	int i;
+
 	hash_for_each_safe(sync->fences, i, tmp, e, node) {
 
 		f = e->fence;
@@ -392,7 +394,7 @@ void amdgpu_sync_free(struct amdgpu_sync *sync)
 {
 	struct amdgpu_sync_entry *e;
 	struct hlist_node *tmp;
-	unsigned i;
+	unsigned int i;
 
 	hash_for_each_safe(sync->fences, i, tmp, e, node) {
 		hash_del(&e->node);
-- 
2.34.1
Re: [PATCH] amd: amdgpu: fix coding style issue
Posted by Christian König 3 years, 7 months ago
Am 04.09.22 um 11:26 schrieb Jingyu Wang:
> This is a patch to the amdgpu_sync.c file that fixes some warnings found by the checkpatch.pl tool
>
> Signed-off-by: Jingyu Wang <jingyuwang_vip@163.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> index 504af1b93bfa..dfc787b749b2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c
> @@ -1,5 +1,6 @@
> -/*
> - * Copyright 2014 Advanced Micro Devices, Inc.
> +// SPDX-License-Identifier: GPL-2.0

This code is under and MIT license.

Christian.

> +
> +/* Copyright 2014 Advanced Micro Devices, Inc.
>    * All Rights Reserved.
>    *
>    * Permission is hereby granted, free of charge, to any person obtaining a
> @@ -315,6 +316,7 @@ struct dma_fence *amdgpu_sync_get_fence(struct amdgpu_sync *sync)
>   	struct hlist_node *tmp;
>   	struct dma_fence *f;
>   	int i;
> +
>   	hash_for_each_safe(sync->fences, i, tmp, e, node) {
>   
>   		f = e->fence;
> @@ -392,7 +394,7 @@ void amdgpu_sync_free(struct amdgpu_sync *sync)
>   {
>   	struct amdgpu_sync_entry *e;
>   	struct hlist_node *tmp;
> -	unsigned i;
> +	unsigned int i;
>   
>   	hash_for_each_safe(sync->fences, i, tmp, e, node) {
>   		hash_del(&e->node);