[PATCH 1/2] dt-bindings: phy: qcom,qmp-usb: add missing power-domains property

Johan Hovold posted 2 patches 3 years, 7 months ago
[PATCH 1/2] dt-bindings: phy: qcom,qmp-usb: add missing power-domains property
Posted by Johan Hovold 3 years, 7 months ago
At least the "sc8280xp-qmp-usb3-uni-phy" binding requires a power domain
to be specified.

Fixes: aa27597e594c ("dt-bindings: phy: qcom,qmp: Add compatible for SC8280XP USB phys")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 .../devicetree/bindings/phy/qcom,qmp-usb-phy.yaml   | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml
index 25e01ec4799d..7acb4b7de7f9 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml
@@ -58,6 +58,9 @@ properties:
     minItems: 3
     maxItems: 4
 
+  power-domains:
+    maxItems: 1
+
   resets:
     maxItems: 2
 
@@ -265,6 +268,16 @@ allOf:
             - const: phy_phy
             - const: phy
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,sc8280xp-qmp-usb3-uni-phy
+    then:
+      required:
+        - power-domains
+
   - if:
       properties:
         compatible:
-- 
2.35.1
Re: [PATCH 1/2] dt-bindings: phy: qcom,qmp-usb: add missing power-domains property
Posted by Rob Herring 3 years, 7 months ago
On Fri, 02 Sep 2022 10:07:04 +0200, Johan Hovold wrote:
> At least the "sc8280xp-qmp-usb3-uni-phy" binding requires a power domain
> to be specified.
> 
> Fixes: aa27597e594c ("dt-bindings: phy: qcom,qmp: Add compatible for SC8280XP USB phys")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  .../devicetree/bindings/phy/qcom,qmp-usb-phy.yaml   | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>