[PATCH V2 0/6] Add sample_flags to improve the perf_sample_data struct

kan.liang@linux.intel.com posted 6 patches 3 years, 7 months ago
arch/powerpc/perf/core-book3s.c | 10 ++++++---
arch/x86/events/amd/core.c      |  4 +++-
arch/x86/events/core.c          |  4 +++-
arch/x86/events/intel/core.c    |  4 +++-
arch/x86/events/intel/ds.c      | 39 ++++++++++++++++++++++++---------
include/linux/perf_event.h      | 15 ++++++-------
kernel/events/core.c            | 30 ++++++++++++++++++-------
7 files changed, 74 insertions(+), 32 deletions(-)
[PATCH V2 0/6] Add sample_flags to improve the perf_sample_data struct
Posted by kan.liang@linux.intel.com 3 years, 7 months ago
From: Kan Liang <kan.liang@linux.intel.com>

Changes since V1:
- Update the AMD LBR code in patch 3

The patch series is to fix PEBS timestamps overwritten and improve the
perf_sample_data struct. The detailed discussion can be found at
https://lore.kernel.org/lkml/YwXvGe4%2FQdgGYOKJ@worktop.programming.kicks-ass.net/

The patch series has two changes compared with the suggestions in the
above discussion.
- Only clear the sample flags for the perf_prepare_sample().
  The __perf_event_header__init_id is shared between perf_prepare_sample()
  (used by PERF_RECORD_SAMPLE) and perf_event_header__init_id() (used by
  other PERF_RECORD_* event type). The sample data is only available
  for the PERF_RECORD_SAMPLE.
- The CALLCHAIN_EARLY hack is still required for the BPF, especially
  perf_event_set_bpf_handler(). The sample data is not available when
  the function is invoked.

Kan Liang (6):
  perf: Add sample_flags to indicate the PMU-filled sample data
  perf/x86/intel/pebs: Fix PEBS timestamps overwritten
  perf: Use sample_flags for branch stack
  perf: Use sample_flags for weight
  perf: Use sample_flags for data_src
  perf: Use sample_flags for txn

 arch/powerpc/perf/core-book3s.c | 10 ++++++---
 arch/x86/events/amd/core.c      |  4 +++-
 arch/x86/events/core.c          |  4 +++-
 arch/x86/events/intel/core.c    |  4 +++-
 arch/x86/events/intel/ds.c      | 39 ++++++++++++++++++++++++---------
 include/linux/perf_event.h      | 15 ++++++-------
 kernel/events/core.c            | 30 ++++++++++++++++++-------
 7 files changed, 74 insertions(+), 32 deletions(-)

-- 
2.35.1
Re: [PATCH V2 0/6] Add sample_flags to improve the perf_sample_data struct
Posted by Namhyung Kim 3 years, 7 months ago
On Thu, Sep 1, 2022 at 6:10 AM <kan.liang@linux.intel.com> wrote:
>
> From: Kan Liang <kan.liang@linux.intel.com>
>
> Changes since V1:
> - Update the AMD LBR code in patch 3
>
> The patch series is to fix PEBS timestamps overwritten and improve the
> perf_sample_data struct. The detailed discussion can be found at
> https://lore.kernel.org/lkml/YwXvGe4%2FQdgGYOKJ@worktop.programming.kicks-ass.net/
>
> The patch series has two changes compared with the suggestions in the
> above discussion.
> - Only clear the sample flags for the perf_prepare_sample().
>   The __perf_event_header__init_id is shared between perf_prepare_sample()
>   (used by PERF_RECORD_SAMPLE) and perf_event_header__init_id() (used by
>   other PERF_RECORD_* event type). The sample data is only available
>   for the PERF_RECORD_SAMPLE.
> - The CALLCHAIN_EARLY hack is still required for the BPF, especially
>   perf_event_set_bpf_handler(). The sample data is not available when
>   the function is invoked.
>
> Kan Liang (6):
>   perf: Add sample_flags to indicate the PMU-filled sample data
>   perf/x86/intel/pebs: Fix PEBS timestamps overwritten
>   perf: Use sample_flags for branch stack
>   perf: Use sample_flags for weight
>   perf: Use sample_flags for data_src
>   perf: Use sample_flags for txn

Maybe we can get rid of perf_sample_data_init() completely.
But it could be done later, so

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


>
>  arch/powerpc/perf/core-book3s.c | 10 ++++++---
>  arch/x86/events/amd/core.c      |  4 +++-
>  arch/x86/events/core.c          |  4 +++-
>  arch/x86/events/intel/core.c    |  4 +++-
>  arch/x86/events/intel/ds.c      | 39 ++++++++++++++++++++++++---------
>  include/linux/perf_event.h      | 15 ++++++-------
>  kernel/events/core.c            | 30 ++++++++++++++++++-------
>  7 files changed, 74 insertions(+), 32 deletions(-)
>
> --
> 2.35.1
>
Re: [PATCH V2 0/6] Add sample_flags to improve the perf_sample_data struct
Posted by Ravi Bangoria 3 years, 7 months ago
On 02-Sep-22 11:02 AM, Namhyung Kim wrote:
> On Thu, Sep 1, 2022 at 6:10 AM <kan.liang@linux.intel.com> wrote:
>>
>> From: Kan Liang <kan.liang@linux.intel.com>
>>
>> Changes since V1:
>> - Update the AMD LBR code in patch 3

Thanks.

I'll also need to rebase my perf mem/c2c series:
https://lore.kernel.org/r/20220616113638.900-1-ravi.bangoria%40amd.com