[PATCH linux-next] fuse: Remove the unneeded result variable

cgel.zte@gmail.com posted 1 patch 3 years, 7 months ago
fs/fuse/cuse.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
[PATCH linux-next] fuse: Remove the unneeded result variable
Posted by cgel.zte@gmail.com 3 years, 7 months ago
From: ye xingchen <ye.xingchen@zte.com.cn>

Return the value fuse_dev_release() directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 fs/fuse/cuse.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/fuse/cuse.c b/fs/fuse/cuse.c
index c7d882a9fe33..a06fbb1a8a5b 100644
--- a/fs/fuse/cuse.c
+++ b/fs/fuse/cuse.c
@@ -545,7 +545,6 @@ static int cuse_channel_release(struct inode *inode, struct file *file)
 {
 	struct fuse_dev *fud = file->private_data;
 	struct cuse_conn *cc = fc_to_cc(fud->fc);
-	int rc;
 
 	/* remove from the conntbl, no more access from this point on */
 	mutex_lock(&cuse_lock);
@@ -560,9 +559,7 @@ static int cuse_channel_release(struct inode *inode, struct file *file)
 		cdev_del(cc->cdev);
 	}
 
-	rc = fuse_dev_release(inode, file);	/* puts the base reference */
-
-	return rc;
+	return fuse_dev_release(inode, file);
 }
 
 static struct file_operations cuse_channel_fops; /* initialized during init */
-- 
2.25.1
Re: [PATCH linux-next] fuse: Remove the unneeded result variable
Posted by Miklos Szeredi 3 years, 5 months ago
On Thu, 1 Sept 2022 at 09:43, <cgel.zte@gmail.com> wrote:
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value fuse_dev_release() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Applied, thanks.

Miklos