[PATCH net-next,v2] net/sched: cls_api: remove redundant 0 check in tcf_qevent_init()

Zhengchao Shao posted 1 patch 3 years, 7 months ago
net/sched/cls_api.c | 3 ---
1 file changed, 3 deletions(-)
[PATCH net-next,v2] net/sched: cls_api: remove redundant 0 check in tcf_qevent_init()
Posted by Zhengchao Shao 3 years, 7 months ago
tcf_qevent_parse_block_index() never returns a zero block_index.
Therefore, it is unnecessary to check the value of block_index in
tcf_qevent_init().

Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
---
 net/sched/cls_api.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index 1ebab4b11262..5d0d57dc5cb7 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -3629,9 +3629,6 @@ int tcf_qevent_init(struct tcf_qevent *qe, struct Qdisc *sch,
 	if (err)
 		return err;
 
-	if (!block_index)
-		return 0;
-
 	qe->info.binder_type = binder_type;
 	qe->info.chain_head_change = tcf_chain_head_change_dflt;
 	qe->info.chain_head_change_priv = &qe->filter_chain;
-- 
2.17.1
Re: [PATCH net-next,v2] net/sched: cls_api: remove redundant 0 check in tcf_qevent_init()
Posted by patchwork-bot+netdevbpf@kernel.org 3 years, 7 months ago
Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 1 Sep 2022 09:16:17 +0800 you wrote:
> tcf_qevent_parse_block_index() never returns a zero block_index.
> Therefore, it is unnecessary to check the value of block_index in
> tcf_qevent_init().
> 
> Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> ---
>  net/sched/cls_api.c | 3 ---
>  1 file changed, 3 deletions(-)

Here is the summary with links:
  - [net-next,v2] net/sched: cls_api: remove redundant 0 check in tcf_qevent_init()
    https://git.kernel.org/netdev/net-next/c/2e5fb3223261

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html