ARM: mmp: Make mmp2_resource_gpio static

[PATCH -next] ARM: mmp: Make mmp2_resource_gpio static

Posted by ruanjinjie 3 years, 7 months ago

The symbol is not used outside of the file, so mark it static.

Fixes the following warning:

./arch/arm/mach-mmp/mmp2.c:157:17: warning: symbol 'mmp2_resource_gpio' was not declared. Should it be static?

Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
---
 arch/arm/mach-mmp/mmp2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-mmp/mmp2.c b/arch/arm/mach-mmp/mmp2.c
index bbc4c2274de3..696bc1856e6d 100644
--- a/arch/arm/mach-mmp/mmp2.c
+++ b/arch/arm/mach-mmp/mmp2.c
@@ -154,7 +154,7 @@ MMP2_DEVICE(asram, "asram", -1, NONE, 0xe0000000, 0x4000);
 /* 0xd1000000 ~ 0xd101ffff is reserved for secure processor */
 MMP2_DEVICE(isram, "isram", -1, NONE, 0xd1020000, 0x18000);
 
-struct resource mmp2_resource_gpio[] = {
+static struct resource mmp2_resource_gpio[] = {
 	{
 		.start	= 0xd4019000,
 		.end	= 0xd4019fff,
-- 
2.25.1

Re: [PATCH -next] ARM: mmp: Make mmp2_resource_gpio static

Posted by Ruan Jinjie 3 years, 6 months ago

Ping.

On 2022/9/1 8:45, ruanjinjie wrote:
> The symbol is not used outside of the file, so mark it static.
> 
> Fixes the following warning:
> 
> ./arch/arm/mach-mmp/mmp2.c:157:17: warning: symbol 'mmp2_resource_gpio' was not declared. Should it be static?
> 
> Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
> ---
>  arch/arm/mach-mmp/mmp2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-mmp/mmp2.c b/arch/arm/mach-mmp/mmp2.c
> index bbc4c2274de3..696bc1856e6d 100644
> --- a/arch/arm/mach-mmp/mmp2.c
> +++ b/arch/arm/mach-mmp/mmp2.c
> @@ -154,7 +154,7 @@ MMP2_DEVICE(asram, "asram", -1, NONE, 0xe0000000, 0x4000);
>  /* 0xd1000000 ~ 0xd101ffff is reserved for secure processor */
>  MMP2_DEVICE(isram, "isram", -1, NONE, 0xd1020000, 0x18000);
>  
> -struct resource mmp2_resource_gpio[] = {
> +static struct resource mmp2_resource_gpio[] = {
>  	{
>  		.start	= 0xd4019000,
>  		.end	= 0xd4019fff,

答复: [PATCH -next] ARM: mmp: Make mmp2_resource_gpio static

Posted by ruanjinjie 3 years, 6 months ago

Ping.

-----邮件原件-----
发件人: ruanjinjie <ruanjinjie@huawei.com> 
发送时间: 2022年9月1日 8:45
收件人: lkundrak@v3.sk; linux@armlinux.org.uk; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
抄送: ruanjinjie <ruanjinjie@huawei.com>
主题: [PATCH -next] ARM: mmp: Make mmp2_resource_gpio static

The symbol is not used outside of the file, so mark it static.

Fixes the following warning:

./arch/arm/mach-mmp/mmp2.c:157:17: warning: symbol 'mmp2_resource_gpio' was not declared. Should it be static?

Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
---
 arch/arm/mach-mmp/mmp2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-mmp/mmp2.c b/arch/arm/mach-mmp/mmp2.c index bbc4c2274de3..696bc1856e6d 100644
--- a/arch/arm/mach-mmp/mmp2.c
+++ b/arch/arm/mach-mmp/mmp2.c
@@ -154,7 +154,7 @@ MMP2_DEVICE(asram, "asram", -1, NONE, 0xe0000000, 0x4000);
 /* 0xd1000000 ~ 0xd101ffff is reserved for secure processor */  MMP2_DEVICE(isram, "isram", -1, NONE, 0xd1020000, 0x18000);
 
-struct resource mmp2_resource_gpio[] = {
+static struct resource mmp2_resource_gpio[] = {
 	{
 		.start	= 0xd4019000,
 		.end	= 0xd4019fff,
--
2.25.1