[PATCH V2 2/6] arm64: dts: imx8ulp: correct the scmi sram node name

Peng Fan (OSS) posted 6 patches 3 years, 7 months ago
[PATCH V2 2/6] arm64: dts: imx8ulp: correct the scmi sram node name
Posted by Peng Fan (OSS) 3 years, 7 months ago
From: Peng Fan <peng.fan@nxp.com>

Follow sram/sram.yaml to update the sram node name.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
index 8460a3cba107..7a88d7016b49 100644
--- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
@@ -112,7 +112,7 @@ sram@2201f000 {
 		#size-cells = <1>;
 		ranges = <0 0x0 0x2201f000 0x1000>;
 
-		scmi_buf: scmi-buf@0 {
+		scmi_buf: scmi-sram-section@0 {
 			compatible = "arm,scmi-shmem";
 			reg = <0x0 0x400>;
 		};
-- 
2.37.1
Re: [PATCH V2 2/6] arm64: dts: imx8ulp: correct the scmi sram node name
Posted by Shawn Guo 3 years, 7 months ago
On Wed, Aug 31, 2022 at 10:25:48PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Follow sram/sram.yaml to update the sram node name.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index 8460a3cba107..7a88d7016b49 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> @@ -112,7 +112,7 @@ sram@2201f000 {
>  		#size-cells = <1>;
>  		ranges = <0 0x0 0x2201f000 0x1000>;
>  
> -		scmi_buf: scmi-buf@0 {
> +		scmi_buf: scmi-sram-section@0 {

While the commit log mentions sram/sram.yaml, the binding doc says:

  $nodename:
    pattern: "^sram(@.*)?"

Does scmi-sram-section match the pattern?

Shawn

>  			compatible = "arm,scmi-shmem";
>  			reg = <0x0 0x400>;
>  		};
> -- 
> 2.37.1
>
RE: [PATCH V2 2/6] arm64: dts: imx8ulp: correct the scmi sram node name
Posted by Peng Fan 3 years, 7 months ago
Hi Shawn,

> Subject: Re: [PATCH V2 2/6] arm64: dts: imx8ulp: correct the scmi sram
> node name
> 
> On Wed, Aug 31, 2022 at 10:25:48PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Follow sram/sram.yaml to update the sram node name.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > index 8460a3cba107..7a88d7016b49 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> > @@ -112,7 +112,7 @@ sram@2201f000 {
> >  		#size-cells = <1>;
> >  		ranges = <0 0x0 0x2201f000 0x1000>;
> >
> > -		scmi_buf: scmi-buf@0 {
> > +		scmi_buf: scmi-sram-section@0 {
> 
> While the commit log mentions sram/sram.yaml, the binding doc says:
> 
>   $nodename:
>     pattern: "^sram(@.*)?"
> 
> Does scmi-sram-section match the pattern?

Yes, it match. See line 66:
patternProperties:
  "^([a-z0-9]*-)?sram(-section)?@[a-f0-9]+$":

I also checked
Documentation/devicetree/bindings/firmware/arm,scmi.yaml

Thanks,
Peng.

> 
> Shawn
> 
> >  			compatible = "arm,scmi-shmem";
> >  			reg = <0x0 0x400>;
> >  		};
> > --
> > 2.37.1
> >