[v1] sched/topology: Add __init for init_defrootdomain

[PATCH RESEND] sched/topology: Add __init for init_defrootdomain

Posted by Bing Huang 3 years, 7 months ago

From: Bing Huang <huangbing@kylinos.cn>

init_defrootdomain is only used in initialization

Signed-off-by: Bing Huang <huangbing@kylinos.cn>
---
 kernel/sched/sched.h    | 2 +-
 kernel/sched/topology.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index b0bf2287dd9d..cd761f1fc60c 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -883,7 +883,7 @@ struct root_domain {
 	struct perf_domain __rcu *pd;
 };
 
-extern void init_defrootdomain(void);
+extern void __init init_defrootdomain(void);
 extern int sched_init_domains(const struct cpumask *cpu_map);
 extern void rq_attach_root(struct rq *rq, struct root_domain *rd);
 extern void sched_get_rd(struct root_domain *rd);
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 8739c2a5a54e..dea9fa39e7c0 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -578,7 +578,7 @@ static int init_rootdomain(struct root_domain *rd)
  */
 struct root_domain def_root_domain;
 
-void init_defrootdomain(void)
+void __init init_defrootdomain(void)
 {
 	init_rootdomain(&def_root_domain);
 
-- 
2.25.1


No virus found
		Checked by Hillstone Network AntiVirus

Re: [PATCH RESEND] sched/topology: Add __init for init_defrootdomain

Posted by Steven Rostedt 3 years, 7 months ago

On Wed, 31 Aug 2022 17:39:27 +0800
Bing Huang <huangbing775@126.com> wrote:

> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index b0bf2287dd9d..cd761f1fc60c 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -883,7 +883,7 @@ struct root_domain {
>  	struct perf_domain __rcu *pd;
>  };
>  
> -extern void init_defrootdomain(void);
> +extern void __init init_defrootdomain(void);

Function prototypes in headers do not need annotations like __init.

-- Steve

>  extern int sched_init_domains(const struct cpumask *cpu_map);
>  extern void rq_attach_root(struct rq *rq, struct root_domain *rd);
>  extern void sched_get_rd(struct root_domain *rd);

Re: [PATCH RESEND] sched/topology: Add __init for init_defrootdomain

Posted by Bing Huang 3 years, 6 months ago

On 9/7/22 08:37, Steven Rostedt wrote:
> On Wed, 31 Aug 2022 17:39:27 +0800
> Bing Huang <huangbing775@126.com> wrote:
>
>> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
>> index b0bf2287dd9d..cd761f1fc60c 100644
>> --- a/kernel/sched/sched.h
>> +++ b/kernel/sched/sched.h
>> @@ -883,7 +883,7 @@ struct root_domain {
>>   	struct perf_domain __rcu *pd;
>>   };
>>   
>> -extern void init_defrootdomain(void);
>> +extern void __init init_defrootdomain(void);
> Function prototypes in headers do not need annotations like __init.
>
> -- Steve
Thanks. I'll send the patch v2 soon.
>
>>   extern int sched_init_domains(const struct cpumask *cpu_map);
>>   extern void rq_attach_root(struct rq *rq, struct root_domain *rd);
>>   extern void sched_get_rd(struct root_domain *rd);

Re: [PATCH RESEND] sched/topology: Add __init for init_defrootdomain

Posted by Randy Dunlap 3 years, 7 months ago


On 8/31/22 02:39, Bing Huang wrote:
> From: Bing Huang <huangbing@kylinos.cn>
> 
> init_defrootdomain is only used in initialization
> 
> Signed-off-by: Bing Huang <huangbing@kylinos.cn>


Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  kernel/sched/sched.h    | 2 +-
>  kernel/sched/topology.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index b0bf2287dd9d..cd761f1fc60c 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -883,7 +883,7 @@ struct root_domain {
>  	struct perf_domain __rcu *pd;
>  };
>  
> -extern void init_defrootdomain(void);
> +extern void __init init_defrootdomain(void);
>  extern int sched_init_domains(const struct cpumask *cpu_map);
>  extern void rq_attach_root(struct rq *rq, struct root_domain *rd);
>  extern void sched_get_rd(struct root_domain *rd);
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 8739c2a5a54e..dea9fa39e7c0 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -578,7 +578,7 @@ static int init_rootdomain(struct root_domain *rd)
>   */
>  struct root_domain def_root_domain;
>  
> -void init_defrootdomain(void)
> +void __init init_defrootdomain(void)
>  {
>  	init_rootdomain(&def_root_domain);
>  

-- 
~Randy