Add uart_xmit_advance() helper to handle circular xmit buffer
advancement + accounting of Tx'ed bytes. Use it to fix a few drivers
that previously lacked to accounting for DMA Tx.

Greg,
I've a another series on top this which is tty-next material making the
rest of the drivers to use uart_xmit_advance(). That series obviously
depends on the patch 1/3 of this series so if you end up putting these
3 patches into tty-linus, I'll need it to be merged into tty-next at
some point (I'm not in a big hurry with this so if you choose to delay
the merge, it's not a big deal).

v2:
- Correct tags

Ilpo Järvinen (3):
  serial: Create uart_xmit_advance()
  serial: tegra: Use uart_xmit_advance(), fixes icount.tx accounting
  serial: tegra-tcu: Use uart_xmit_advance(), fixes icount.tx accounting

 drivers/tty/serial/serial-tegra.c |  5 ++---
 drivers/tty/serial/tegra-tcu.c    |  2 +-
 include/linux/serial_core.h       | 17 +++++++++++++++++
 3 files changed, 20 insertions(+), 4 deletions(-)

-- 
2.30.2

On Tue, 30 Aug 2022, Ilpo Järvinen wrote:

> Add uart_xmit_advance() helper to handle circular xmit buffer
> advancement + accounting of Tx'ed bytes. Use it to fix a few drivers
> that previously lacked to accounting for DMA Tx.
> 
> Greg,
> I've a another series on top this which is tty-next material making the
> rest of the drivers to use uart_xmit_advance(). That series obviously
> depends on the patch 1/3 of this series so if you end up putting these
> 3 patches into tty-linus, I'll need it to be merged into tty-next at
> some point (I'm not in a big hurry with this so if you choose to delay
> the merge, it's not a big deal).

This merge, btw, is no longer that important because I agreed with Jiri to 
wait for his tx loop rewrite series.

-- 
 i.

> v2:
> - Correct tags
> 
> Ilpo Järvinen (3):
>   serial: Create uart_xmit_advance()
>   serial: tegra: Use uart_xmit_advance(), fixes icount.tx accounting
>   serial: tegra-tcu: Use uart_xmit_advance(), fixes icount.tx accounting
> 
>  drivers/tty/serial/serial-tegra.c |  5 ++---
>  drivers/tty/serial/tegra-tcu.c    |  2 +-
>  include/linux/serial_core.h       | 17 +++++++++++++++++
>  3 files changed, 20 insertions(+), 4 deletions(-)
> 
> 

On Tue, Aug 30, 2022 at 04:19:40PM +0300, Ilpo Järvinen wrote:
> On Tue, 30 Aug 2022, Ilpo Järvinen wrote:
> 
> > Add uart_xmit_advance() helper to handle circular xmit buffer
> > advancement + accounting of Tx'ed bytes. Use it to fix a few drivers
> > that previously lacked to accounting for DMA Tx.
> > 
> > Greg,
> > I've a another series on top this which is tty-next material making the
> > rest of the drivers to use uart_xmit_advance(). That series obviously
> > depends on the patch 1/3 of this series so if you end up putting these
> > 3 patches into tty-linus, I'll need it to be merged into tty-next at
> > some point (I'm not in a big hurry with this so if you choose to delay
> > the merge, it's not a big deal).
> 
> This merge, btw, is no longer that important because I agreed with Jiri to 
> wait for his tx loop rewrite series.

Ok, I'll drop this series for now.

thanks,

greg k-h

On Thu, 1 Sep 2022, Greg Kroah-Hartman wrote:

> On Tue, Aug 30, 2022 at 04:19:40PM +0300, Ilpo Järvinen wrote:
> > On Tue, 30 Aug 2022, Ilpo Järvinen wrote:
> > 
> > > Add uart_xmit_advance() helper to handle circular xmit buffer
> > > advancement + accounting of Tx'ed bytes. Use it to fix a few drivers
> > > that previously lacked to accounting for DMA Tx.
> > > 
> > > Greg,
> > > I've a another series on top this which is tty-next material making the
> > > rest of the drivers to use uart_xmit_advance(). That series obviously
> > > depends on the patch 1/3 of this series so if you end up putting these
> > > 3 patches into tty-linus, I'll need it to be merged into tty-next at
> > > some point (I'm not in a big hurry with this so if you choose to delay
> > > the merge, it's not a big deal).
> > 
> > This merge, btw, is no longer that important because I agreed with Jiri to 
> > wait for his tx loop rewrite series.
> 
> Ok, I'll drop this series for now.

It's not what I meant.

I've a follow-up series on top of this which depeds on uart_xmit_advance() 
being available (thus I'd have need it in tty-next). However, now I'm 
postponing the follow-up series while Jiri sorts out the tx loops.

This first part of the series and Jiri's tx loop series don't even touch 
the same files.

I guess I should resend these if you dropped these from your queue?


-- 
 i.

On Thu, Sep 01, 2022 at 05:15:11PM +0300, Ilpo Järvinen wrote:
> On Thu, 1 Sep 2022, Greg Kroah-Hartman wrote:
> 
> > On Tue, Aug 30, 2022 at 04:19:40PM +0300, Ilpo Järvinen wrote:
> > > On Tue, 30 Aug 2022, Ilpo Järvinen wrote:
> > > 
> > > > Add uart_xmit_advance() helper to handle circular xmit buffer
> > > > advancement + accounting of Tx'ed bytes. Use it to fix a few drivers
> > > > that previously lacked to accounting for DMA Tx.
> > > > 
> > > > Greg,
> > > > I've a another series on top this which is tty-next material making the
> > > > rest of the drivers to use uart_xmit_advance(). That series obviously
> > > > depends on the patch 1/3 of this series so if you end up putting these
> > > > 3 patches into tty-linus, I'll need it to be merged into tty-next at
> > > > some point (I'm not in a big hurry with this so if you choose to delay
> > > > the merge, it's not a big deal).
> > > 
> > > This merge, btw, is no longer that important because I agreed with Jiri to 
> > > wait for his tx loop rewrite series.
> > 
> > Ok, I'll drop this series for now.
> 
> It's not what I meant.
> 
> I've a follow-up series on top of this which depeds on uart_xmit_advance() 
> being available (thus I'd have need it in tty-next). However, now I'm 
> postponing the follow-up series while Jiri sorts out the tx loops.
> 
> This first part of the series and Jiri's tx loop series don't even touch 
> the same files.
> 
> I guess I should resend these if you dropped these from your queue?

Yes please, sorry, I was confused.

greg k-h