[PATCH net-next 0/2] net: sched: remove redundant resource cleanup when init() fails

Zhengchao Shao posted 2 patches 3 years, 7 months ago
There is a newer version of this series
net/sched/sch_fq_codel.c | 17 ++++-------------
net/sched/sch_htb.c      | 36 +++++++++---------------------------
2 files changed, 13 insertions(+), 40 deletions(-)
[PATCH net-next 0/2] net: sched: remove redundant resource cleanup when init() fails
Posted by Zhengchao Shao 3 years, 7 months ago
qdisc_create() calls .init() to initialize qdisc. If the initialization
fails, qdisc_create() will call .destroy() to release resources.

Zhengchao Shao (2):
  net: sched: fq_codel: remove redundant resource cleanup in
    fq_codel_init()
  net: sched: htb: remove redundant resource cleanup in htb_init()

 net/sched/sch_fq_codel.c | 17 ++++-------------
 net/sched/sch_htb.c      | 36 +++++++++---------------------------
 2 files changed, 13 insertions(+), 40 deletions(-)

-- 
2.17.1
Re: [PATCH net-next 0/2] net: sched: remove redundant resource cleanup when init() fails
Posted by Jakub Kicinski 3 years, 7 months ago
On Tue, 30 Aug 2022 08:56:36 +0800 Zhengchao Shao wrote:
> qdisc_create() calls .init() to initialize qdisc. If the initialization
> fails, qdisc_create() will call .destroy() to release resources.

Looks like this set does not apply cleanly, please rebase on top 
of latest net-next/main and repost.