[v1] virt: sev-guest: fix kconfig warnings

[PATCH] virt: sev-guest: fix kconfig warnings

Posted by Randy Dunlap 3 years, 7 months ago

Fix the SEV_GUEST Kconfig block to eliminate kconfig unmet
dependency warnings:

WARNING: unmet direct dependencies detected for CRYPTO_GCM
  Depends on [n]: CRYPTO [=n]
  Selected by [y]:
  - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]

WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
  Depends on [n]: CRYPTO [=n]
  Selected by [y]:
  - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]

Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: stable@vger.kernel.org
Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Paul Gazzillo <paul@pgazz.com>
Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: linux-crypto@vger.kernel.org
---
 drivers/virt/coco/sev-guest/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- a/drivers/virt/coco/sev-guest/Kconfig
+++ b/drivers/virt/coco/sev-guest/Kconfig
@@ -2,6 +2,7 @@ config SEV_GUEST
 	tristate "AMD SEV Guest driver"
 	default m
 	depends on AMD_MEM_ENCRYPT
+	select CRYPTO
 	select CRYPTO_AEAD2
 	select CRYPTO_GCM
 	help

Re: [PATCH] virt: sev-guest: fix kconfig warnings

Posted by Randy Dunlap 3 years, 5 months ago

ping. I have verified (on linux-next-20221103) that this
patch is still needed.
Thanks.

On 8/28/22 12:52, Randy Dunlap wrote:
> Fix the SEV_GUEST Kconfig block to eliminate kconfig unmet
> dependency warnings:
> 
> WARNING: unmet direct dependencies detected for CRYPTO_GCM
>   Depends on [n]: CRYPTO [=n]
>   Selected by [y]:
>   - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
> 
> WARNING: unmet direct dependencies detected for CRYPTO_AEAD2
>   Depends on [n]: CRYPTO [=n]
>   Selected by [y]:
>   - SEV_GUEST [=y] && VIRT_DRIVERS [=y] && AMD_MEM_ENCRYPT [=y]
> 
> Fixes: fce96cf04430 ("virt: Add SEV-SNP guest driver")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: stable@vger.kernel.org
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Paul Gazzillo <paul@pgazz.com>
> Cc: Necip Fazil Yildiran <fazilyildiran@gmail.com>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: linux-crypto@vger.kernel.org
> ---
>  drivers/virt/coco/sev-guest/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/virt/coco/sev-guest/Kconfig
> +++ b/drivers/virt/coco/sev-guest/Kconfig
> @@ -2,6 +2,7 @@ config SEV_GUEST
>  	tristate "AMD SEV Guest driver"
>  	default m
>  	depends on AMD_MEM_ENCRYPT
> +	select CRYPTO
>  	select CRYPTO_AEAD2
>  	select CRYPTO_GCM
>  	help

-- 
~Randy