[PATCH] crypto: hisilicon/qm - return failure if vfs_num exceeds total VFs

Weili Qian posted 1 patch 3 years, 7 months ago
drivers/crypto/hisilicon/qm.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
[PATCH] crypto: hisilicon/qm - return failure if vfs_num exceeds total VFs
Posted by Weili Qian 3 years, 7 months ago
The accelerator drivers supports users to enable VFs through the
module parameter 'vfs_num'. If the number of VFs to be enabled
exceeds the total VFs, all VFs are enabled. Change it to the same
as enabling VF through the 'sriov_numvfs' file. Returns -ERANGE
if the number of VFs to be enabled exceeds total VFs.

Signed-off-by: Weili Qian <qianweili@huawei.com>
---
 drivers/crypto/hisilicon/qm.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index fd9fb159048f..54bbd7fa57cc 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -4766,7 +4766,13 @@ int hisi_qm_sriov_enable(struct pci_dev *pdev, int max_vfs)
 		goto err_put_sync;
 	}
 
-	num_vfs = min_t(int, max_vfs, total_vfs);
+	if (max_vfs > total_vfs) {
+		pci_err(pdev, "%d VFs is more than total VFs %d!\n", max_vfs, total_vfs);
+		ret = -ERANGE;
+		goto err_put_sync;
+	}
+
+	num_vfs = max_vfs;
 	ret = qm_vf_q_assign(qm, num_vfs);
 	if (ret) {
 		pci_err(pdev, "Can't assign queues for VF!\n");
-- 
2.33.0
Re: [PATCH] crypto: hisilicon/qm - return failure if vfs_num exceeds total VFs
Posted by Herbert Xu 3 years, 7 months ago
On Sat, Aug 27, 2022 at 06:27:56PM +0800, Weili Qian wrote:
> The accelerator drivers supports users to enable VFs through the
> module parameter 'vfs_num'. If the number of VFs to be enabled
> exceeds the total VFs, all VFs are enabled. Change it to the same
> as enabling VF through the 'sriov_numvfs' file. Returns -ERANGE
> if the number of VFs to be enabled exceeds total VFs.
> 
> Signed-off-by: Weili Qian <qianweili@huawei.com>
> ---
>  drivers/crypto/hisilicon/qm.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt