[PATCH] RDMA/core: remove 'device' argument from rdma_build_skb()

Yunsheng Lin posted 1 patch 3 years, 7 months ago
drivers/infiniband/core/lag.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
[PATCH] RDMA/core: remove 'device' argument from rdma_build_skb()
Posted by Yunsheng Lin 3 years, 7 months ago
'device' argument is never used since rdma_build_skb()
is introduced, so remove it.

Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
---
 drivers/infiniband/core/lag.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/core/lag.c b/drivers/infiniband/core/lag.c
index 7063e41eaf26..c77d7d2559a1 100644
--- a/drivers/infiniband/core/lag.c
+++ b/drivers/infiniband/core/lag.c
@@ -7,8 +7,7 @@
 #include <rdma/ib_cache.h>
 #include <rdma/lag.h>
 
-static struct sk_buff *rdma_build_skb(struct ib_device *device,
-				      struct net_device *netdev,
+static struct sk_buff *rdma_build_skb(struct net_device *netdev,
 				      struct rdma_ah_attr *ah_attr,
 				      gfp_t flags)
 {
@@ -86,7 +85,7 @@ static struct net_device *rdma_get_xmit_slave_udp(struct ib_device *device,
 	struct net_device *slave;
 	struct sk_buff *skb;
 
-	skb = rdma_build_skb(device, master, ah_attr, flags);
+	skb = rdma_build_skb(master, ah_attr, flags);
 	if (!skb)
 		return ERR_PTR(-ENOMEM);
 
-- 
2.33.0
Re: [PATCH] RDMA/core: remove 'device' argument from rdma_build_skb()
Posted by Leon Romanovsky 3 years, 7 months ago
On Fri, Aug 26, 2022 at 10:32:15PM +0800, Yunsheng Lin wrote:
> 'device' argument is never used since rdma_build_skb()
> is introduced, so remove it.
> 
> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
> ---
>  drivers/infiniband/core/lag.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 

Thanks, applied.