[PATCH linux-next] scsi: mpt3sas: Remove the unneeded result variable

cgel.zte@gmail.com posted 1 patch 3 years, 7 months ago
drivers/scsi/mpt3sas/mpt3sas_base.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
[PATCH linux-next] scsi: mpt3sas: Remove the unneeded result variable
Posted by cgel.zte@gmail.com 3 years, 7 months ago
From: ye xingchen <ye.xingchen@zte.com.cn>

Return the value _base_diag_reset() directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/scsi/mpt3sas/mpt3sas_base.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index 565339a0811d..26f5897a5c7c 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -7170,7 +7170,6 @@ static int
 _base_wait_for_iocstate(struct MPT3SAS_ADAPTER *ioc, int timeout)
 {
 	u32 ioc_state;
-	int rc;
 
 	dinitprintk(ioc, ioc_info(ioc, "%s\n", __func__));
 
@@ -7216,8 +7215,7 @@ _base_wait_for_iocstate(struct MPT3SAS_ADAPTER *ioc, int timeout)
 	}
 
  issue_diag_reset:
-	rc = _base_diag_reset(ioc);
-	return rc;
+	return _base_diag_reset(ioc);
 }
 
 /**
@@ -7879,7 +7877,6 @@ int
 mpt3sas_base_make_ioc_ready(struct MPT3SAS_ADAPTER *ioc, enum reset_type type)
 {
 	u32 ioc_state;
-	int rc;
 	int count;
 
 	dinitprintk(ioc, ioc_info(ioc, "%s\n", __func__));
@@ -7948,8 +7945,7 @@ mpt3sas_base_make_ioc_ready(struct MPT3SAS_ADAPTER *ioc, enum reset_type type)
 	}
 
  issue_diag_reset:
-	rc = _base_diag_reset(ioc);
-	return rc;
+	return _base_diag_reset(ioc);
 }
 
 /**
-- 
2.25.1