dt-bindings: iio: Add missing (unevaluated|additional)Properties on child nodes

[PATCH] dt-bindings: iio: Add missing (unevaluated|additional)Properties on child nodes

Posted by Rob Herring 3 years, 7 months ago

In order to ensure only documented properties are present, node schemas
must have unevaluatedProperties or additionalProperties set to false
(typically).

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml | 1 +
 .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml       | 2 ++
 Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml     | 1 +
 .../devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml          | 1 +
 Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml | 1 +
 Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml    | 1 +
 Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml    | 4 ++++
 Documentation/devicetree/bindings/iio/dac/adi,ltc2688.yaml    | 1 +
 8 files changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
index 74a4a9d95798..8bac0c4120dd 100644
--- a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml
@@ -58,6 +58,7 @@ required:
 patternProperties:
   "^.*@[0-9a-f]+$":
     type: object
+    additionalProperties: false
     description: |
       Represents the external channels which are connected to the ADC.
       For compatible property "qcom,spmi-vadc" following channels, also known as
diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
index 92f9472a77ae..1970503389aa 100644
--- a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
@@ -72,6 +72,7 @@ additionalProperties: false
 patternProperties:
   "^filter@[0-9]+$":
     type: object
+    unevaluatedProperties: false
     description: child node
 
     properties:
@@ -225,6 +226,7 @@ patternProperties:
           patternProperties:
             "^dfsdm-dai+$":
               type: object
+              additionalProperties: false
               description: child node
 
               properties:
diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
index a3b79438a13a..2c3c2cf2145c 100644
--- a/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1015.yaml
@@ -43,6 +43,7 @@ additionalProperties: false
 patternProperties:
   "^channel@[0-7]+$":
     type: object
+    additionalProperties: false
     description:
       Child nodes needed for each channel that the platform uses.
 
diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
index 3698b4b0900f..be93c109d6ac 100644
--- a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
@@ -134,6 +134,7 @@ properties:
 
   ams-pl@400:
     type: object
+    additionalProperties: false
     description:
       PL-SYSMON is capable of monitoring off chip voltage and temperature.
       PL-SYSMON block has DRP, JTAG and I2C interface to enable monitoring
diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml
index baa65a521bad..03bb90a7f4f8 100644
--- a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml
+++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml
@@ -63,6 +63,7 @@ additionalProperties: false
 patternProperties:
   "^channel@[0-3]$":
     type: object
+    additionalProperties: false
     description: Represents the external channels which are connected to the device.
 
     properties:
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
index 9c48c76993fe..fee0f023a8c8 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
@@ -78,6 +78,7 @@ patternProperties:
 
       custom-output-range-config:
         type: object
+        additionalProperties: false
         description: Configuration of custom range when
           adi,output-range-microvolt is not present.
           The formulas for calculation the output voltages are
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
index 24ac40180ac1..c2d9ae3039b2 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
@@ -62,6 +62,7 @@ properties:
       connected to the DAC. Channel 0 can act both as a current
       source and sink.
     type: object
+    additionalProperties: false
 
     properties:
       reg:
@@ -85,6 +86,7 @@ properties:
     description: Represents an external channel which are
       connected to the DAC.
     type: object
+    additionalProperties: false
 
     properties:
       reg:
@@ -101,6 +103,7 @@ properties:
     description: Represents an external channel which are
       connected to the DAC.
     type: object
+    additionalProperties: false
 
     properties:
       reg:
@@ -116,6 +119,7 @@ properties:
 patternProperties:
   "^channel@([3-5])$":
     type: object
+    additionalProperties: false
     description: Represents the external channels which are connected to the DAC.
     properties:
       reg:
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ltc2688.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ltc2688.yaml
index 48f9e7d29423..15cc6bf59b13 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ltc2688.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ltc2688.yaml
@@ -48,6 +48,7 @@ properties:
 patternProperties:
   "^channel@([0-9]|1[0-5])$":
     type: object
+    additionalProperties: false
 
     properties:
       reg:
-- 
2.34.1

Re: [PATCH] dt-bindings: iio: Add missing (unevaluated|additional)Properties on child nodes

Posted by Krzysztof Kozlowski 3 years, 7 months ago

On 23/08/2022 17:56, Rob Herring wrote:
> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

Re: [PATCH] dt-bindings: iio: Add missing (unevaluated|additional)Properties on child nodes

Posted by Jonathan Cameron 3 years, 7 months ago

On Thu, 25 Aug 2022 15:04:33 +0300
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 23/08/2022 17:56, Rob Herring wrote:
> > In order to ensure only documented properties are present, node schemas
> > must have unevaluatedProperties or additionalProperties set to false
> > (typically).
> >   
> 
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to poke at it before I push out as togreg for linux-next to pick up.

Side note. Some odd entries in your cc list...  alsa-devel?

Thanks,

Jonathan

> 
> 
> Best regards,
> Krzysztof

Re: [PATCH] dt-bindings: iio: Add missing (unevaluated|additional)Properties on child nodes

Posted by Rob Herring 3 years, 7 months ago

On Sun, Aug 28, 2022 at 06:01:41PM +0100, Jonathan Cameron wrote:
> On Thu, 25 Aug 2022 15:04:33 +0300
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> 
> > On 23/08/2022 17:56, Rob Herring wrote:
> > > In order to ensure only documented properties are present, node schemas
> > > must have unevaluatedProperties or additionalProperties set to false
> > > (typically).
> > >   
> > 
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Applied to the togreg branch of iio.git and pushed out as testing for 0-day
> to poke at it before I push out as togreg for linux-next to pick up.

Thanks.

> Side note. Some odd entries in your cc list...  alsa-devel?

Blame MAINTAINERS:

STM32 AUDIO (ASoC) DRIVERS
M:      Olivier Moysan <olivier.moysan@foss.st.com>
M:      Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
L:      alsa-devel@alsa-project.org (moderated for non-subscribers)
S:      Maintained
F:      Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
F:      Documentation/devicetree/bindings/sound/st,stm32-*.yaml
F:      sound/soc/stm/

Re: [PATCH] dt-bindings: iio: Add missing (unevaluated|additional)Properties on child nodes

Posted by Jonathan Cameron 3 years, 7 months ago

On Mon, 29 Aug 2022 09:10:29 -0500
Rob Herring <robh@kernel.org> wrote:

> On Sun, Aug 28, 2022 at 06:01:41PM +0100, Jonathan Cameron wrote:
> > On Thu, 25 Aug 2022 15:04:33 +0300
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> >   
> > > On 23/08/2022 17:56, Rob Herring wrote:  
> > > > In order to ensure only documented properties are present, node schemas
> > > > must have unevaluatedProperties or additionalProperties set to false
> > > > (typically).
> > > >     
> > > 
> > > 
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>  
> > 
> > Applied to the togreg branch of iio.git and pushed out as testing for 0-day
> > to poke at it before I push out as togreg for linux-next to pick up.  
> 
> Thanks.
> 
> > Side note. Some odd entries in your cc list...  alsa-devel?  
> 
> Blame MAINTAINERS:
> 
> STM32 AUDIO (ASoC) DRIVERS
> M:      Olivier Moysan <olivier.moysan@foss.st.com>
> M:      Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
> L:      alsa-devel@alsa-project.org (moderated for non-subscribers)
> S:      Maintained
> F:      Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml
> F:      Documentation/devicetree/bindings/sound/st,stm32-*.yaml
> F:      sound/soc/stm/

There is some logic to that entry I suppose.

Thanks for explanation!

Jonathan