[PATCH] dt-bindings: timer: Add missing (unevaluated|additional)Properties on child nodes

Rob Herring posted 1 patch 3 years, 7 months ago
.../devicetree/bindings/timer/arm,arch_timer_mmio.yaml        | 1 +
Documentation/devicetree/bindings/timer/ingenic,tcu.yaml      | 4 ++++
2 files changed, 5 insertions(+)
[PATCH] dt-bindings: timer: Add missing (unevaluated|additional)Properties on child nodes
Posted by Rob Herring 3 years, 7 months ago
In order to ensure only documented properties are present, node schemas
must have unevaluatedProperties or additionalProperties set to false
(typically).

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml        | 1 +
 Documentation/devicetree/bindings/timer/ingenic,tcu.yaml      | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
index cd2176cad53a..f6efa48c4256 100644
--- a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
+++ b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
@@ -62,6 +62,7 @@ properties:
 patternProperties:
   '^frame@[0-9a-z]*$':
     type: object
+    additionalProperties: false
     description: A timer node has up to 8 frame sub-nodes, each with the following properties.
     properties:
       frame-number:
diff --git a/Documentation/devicetree/bindings/timer/ingenic,tcu.yaml b/Documentation/devicetree/bindings/timer/ingenic,tcu.yaml
index 0a01e4f5eddb..a84fef0fe628 100644
--- a/Documentation/devicetree/bindings/timer/ingenic,tcu.yaml
+++ b/Documentation/devicetree/bindings/timer/ingenic,tcu.yaml
@@ -114,6 +114,8 @@ patternProperties:
   "^watchdog@[a-f0-9]+$":
     type: object
     $ref: /schemas/watchdog/watchdog.yaml#
+    unevaluatedProperties: false
+
     properties:
       compatible:
         oneOf:
@@ -146,6 +148,8 @@ patternProperties:
   "^pwm@[a-f0-9]+$":
     type: object
     $ref: /schemas/pwm/pwm.yaml#
+    unevaluatedProperties: false
+
     properties:
       compatible:
         oneOf:
-- 
2.34.1
Re: [PATCH] dt-bindings: timer: Add missing (unevaluated|additional)Properties on child nodes
Posted by Rob Herring 3 years, 7 months ago
On Tue, 23 Aug 2022 09:56:47 -0500, Rob Herring wrote:
> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml        | 1 +
>  Documentation/devicetree/bindings/timer/ingenic,tcu.yaml      | 4 ++++
>  2 files changed, 5 insertions(+)
> 

Applied, thanks!
Re: [PATCH] dt-bindings: timer: Add missing (unevaluated|additional)Properties on child nodes
Posted by Krzysztof Kozlowski 3 years, 7 months ago
On 23/08/2022 17:56, Rob Herring wrote:
> In order to ensure only documented properties are present, node schemas
> must have unevaluatedProperties or additionalProperties set to false
> (typically).
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof