[v3] i2c-imx-lpi2c: add IPG clock

[PATCH V3 0/7] i2c-imx-lpi2c: add IPG clock

Posted by Peng Fan (OSS) 3 years, 7 months ago

From: Peng Fan <peng.fan@nxp.com>

V3:
 Add R-b
 Correct clk_bulk_disable to clk_bulk_disable_unprepare in patch 7

V2:
 use clk bulk API in driver to support backward compatibility.
 Include a new patch, patch 1.

The i.MX LPI2C needs PER and IPG clock, not just PER or IPG clock.
The current driver/dts/bindings use one CLK. Although it works with
upstream kernel, but it not match the hardware design. If IPG clock is
disabled, the LPI2C will not work.

There are changes made to ARM32 i.MX7ULP dts, ARM64 i.MX8 dts, dt-
bindings, and the lpi2c driver.

The driver is updated to use bulk clk API to avoid break backward
compatibility. But it is hard to avoid dtbs_check pass, because the dts and
binding update are in separate patches.

Peng Fan (7):
  ARM: dts: imx7ulp: update the LPI2C clock-names
  dt-bindings: i2c: i2c-imx-lpi2c: add ipg clk
  dt-bindings: i2c: i2c-imx-lpi2c: add dmas property
  dt-bindings: i2c: i2c-imx-lpi2c: add i.MX93
  arm64: dts: imx8-ss-dma: add IPG clock for i2c
  ARM: dts: imx7ulp: Add IPG clock for lpi2c
  i2c: imx-lpi2c: use bulk clk API

 .../bindings/i2c/i2c-imx-lpi2c.yaml           | 20 +++++++++++++---
 arch/arm/boot/dts/imx7ulp.dtsi                | 10 ++++----
 .../arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 20 +++++++++-------
 drivers/i2c/busses/i2c-imx-lpi2c.c            | 24 +++++++++----------
 4 files changed, 47 insertions(+), 27 deletions(-)

-- 
2.37.1

Re: [PATCH V3 0/7] i2c-imx-lpi2c: add IPG clock

Posted by Shawn Guo 3 years, 7 months ago

On Tue, Aug 23, 2022 at 11:02:08AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> V3:
>  Add R-b
>  Correct clk_bulk_disable to clk_bulk_disable_unprepare in patch 7
> 
> V2:
>  use clk bulk API in driver to support backward compatibility.
>  Include a new patch, patch 1.
> 
> The i.MX LPI2C needs PER and IPG clock, not just PER or IPG clock.
> The current driver/dts/bindings use one CLK. Although it works with
> upstream kernel, but it not match the hardware design. If IPG clock is
> disabled, the LPI2C will not work.
> 
> There are changes made to ARM32 i.MX7ULP dts, ARM64 i.MX8 dts, dt-
> bindings, and the lpi2c driver.
> 
> The driver is updated to use bulk clk API to avoid break backward
> compatibility. But it is hard to avoid dtbs_check pass, because the dts and
> binding update are in separate patches.
> 
> Peng Fan (7):
>   ARM: dts: imx7ulp: update the LPI2C clock-names
>   dt-bindings: i2c: i2c-imx-lpi2c: add ipg clk
>   dt-bindings: i2c: i2c-imx-lpi2c: add dmas property
>   dt-bindings: i2c: i2c-imx-lpi2c: add i.MX93
>   arm64: dts: imx8-ss-dma: add IPG clock for i2c
>   ARM: dts: imx7ulp: Add IPG clock for lpi2c
>   i2c: imx-lpi2c: use bulk clk API

Applied 3 DTS patches, thanks!