The symbol is not used outside of the file, so mark it static.

Fixes the following warning:

arch/x86/kernel/i8259.c:410:19: warning:
	symbol 'default_legacy_pic' was not declared. Should it be static?

Signed-off-by: Chen Lifu <chenlifu@huawei.com>
---
 arch/x86/kernel/i8259.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c
index 15aefa3f3e18..3aa5304200c5 100644
--- a/arch/x86/kernel/i8259.c
+++ b/arch/x86/kernel/i8259.c
@@ -405,11 +405,11 @@ struct legacy_pic null_legacy_pic = {
 	.probe = legacy_pic_probe,
 	.irq_pending = legacy_pic_irq_pending_noop,
 	.make_irq = legacy_pic_uint_noop,
 };
 
-struct legacy_pic default_legacy_pic = {
+static struct legacy_pic default_legacy_pic = {
 	.nr_legacy_irqs = NR_IRQS_LEGACY,
 	.chip  = &i8259A_chip,
 	.mask = mask_8259A_irq,
 	.unmask = unmask_8259A_irq,
 	.mask_all = mask_8259A,
-- 
2.37.1

在 2022/8/23 10:19, Chen Lifu 写道:
> The symbol is not used outside of the file, so mark it static.
> 
> Fixes the following warning:
> 
> arch/x86/kernel/i8259.c:410:19: warning:
> 	symbol 'default_legacy_pic' was not declared. Should it be static?
> 
> Signed-off-by: Chen Lifu <chenlifu@huawei.com>
> ---
>   arch/x86/kernel/i8259.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c
> index 15aefa3f3e18..3aa5304200c5 100644
> --- a/arch/x86/kernel/i8259.c
> +++ b/arch/x86/kernel/i8259.c
> @@ -405,11 +405,11 @@ struct legacy_pic null_legacy_pic = {
>   	.probe = legacy_pic_probe,
>   	.irq_pending = legacy_pic_irq_pending_noop,
>   	.make_irq = legacy_pic_uint_noop,
>   };
>   
> -struct legacy_pic default_legacy_pic = {
> +static struct legacy_pic default_legacy_pic = {
>   	.nr_legacy_irqs = NR_IRQS_LEGACY,
>   	.chip  = &i8259A_chip,
>   	.mask = mask_8259A_irq,
>   	.unmask = unmask_8259A_irq,
>   	.mask_all = mask_8259A,

Friendly ping ...

The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID:     c9053e1c5a6fca221946f95d1fe6e47f69fb303a
Gitweb:        https://git.kernel.org/tip/c9053e1c5a6fca221946f95d1fe6e47f69fb303a
Author:        Chen Lifu <chenlifu@huawei.com>
AuthorDate:    Tue, 23 Aug 2022 10:19:58 +08:00
Committer:     Borislav Petkov <bp@suse.de>
CommitterDate: Mon, 31 Oct 2022 10:20:32 +01:00

x86/i8259: Make default_legacy_pic static

The symbol is not used outside of the file, so mark it static.

Signed-off-by: Chen Lifu <chenlifu@huawei.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20220823021958.3052493-1-chenlifu@huawei.com
---
 arch/x86/kernel/i8259.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/i8259.c b/arch/x86/kernel/i8259.c
index 15aefa3..3aa5304 100644
--- a/arch/x86/kernel/i8259.c
+++ b/arch/x86/kernel/i8259.c
@@ -407,7 +407,7 @@ struct legacy_pic null_legacy_pic = {
 	.make_irq = legacy_pic_uint_noop,
 };
 
-struct legacy_pic default_legacy_pic = {
+static struct legacy_pic default_legacy_pic = {
 	.nr_legacy_irqs = NR_IRQS_LEGACY,
 	.chip  = &i8259A_chip,
 	.mask = mask_8259A_irq,