[PATCH -next] x86/tsc: Make art_related_clocksource static

Chen Lifu posted 1 patch 3 years, 7 months ago
There is a newer version of this series
arch/x86/kernel/tsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH -next] x86/tsc: Make art_related_clocksource static
Posted by Chen Lifu 3 years, 7 months ago
The symbol is not used outside of the file, so mark it static.

Fixes the following warning:

arch/x86/kernel/tsc.c:53:20: warning:
	symbol 'art_related_clocksource' was not declared. Should it be static?

Signed-off-by: Chen Lifu <chenlifu@huawei.com>
---
 arch/x86/kernel/tsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index cafacb2e58cc..a78e73da4a74 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -49,11 +49,11 @@ static DEFINE_STATIC_KEY_FALSE(__use_tsc);
 int tsc_clocksource_reliable;
 
 static u32 art_to_tsc_numerator;
 static u32 art_to_tsc_denominator;
 static u64 art_to_tsc_offset;
-struct clocksource *art_related_clocksource;
+static struct clocksource *art_related_clocksource;
 
 struct cyc2ns {
 	struct cyc2ns_data data[2];	/*  0 + 2*16 = 32 */
 	seqcount_latch_t   seq;		/* 32 + 4    = 36 */
 
-- 
2.37.1
Re: [PATCH -next] x86/tsc: Make art_related_clocksource static
Posted by chenlifu 3 years, 6 months ago
在 2022/8/23 10:18, Chen Lifu 写道:
> The symbol is not used outside of the file, so mark it static.
> 
> Fixes the following warning:
> 
> arch/x86/kernel/tsc.c:53:20: warning:
> 	symbol 'art_related_clocksource' was not declared. Should it be static?
> 
> Signed-off-by: Chen Lifu <chenlifu@huawei.com>
> ---
>   arch/x86/kernel/tsc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index cafacb2e58cc..a78e73da4a74 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -49,11 +49,11 @@ static DEFINE_STATIC_KEY_FALSE(__use_tsc);
>   int tsc_clocksource_reliable;
>   
>   static u32 art_to_tsc_numerator;
>   static u32 art_to_tsc_denominator;
>   static u64 art_to_tsc_offset;
> -struct clocksource *art_related_clocksource;
> +static struct clocksource *art_related_clocksource;
>   
>   struct cyc2ns {
>   	struct cyc2ns_data data[2];	/*  0 + 2*16 = 32 */
>   	seqcount_latch_t   seq;		/* 32 + 4    = 36 */
>   

friendly ping ...
[tip: x86/cleanups] x86/tsc: Make art_related_clocksource static
Posted by tip-bot2 for Chen Lifu 3 years, 5 months ago
The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID:     3548eda8ae284d6d412d59f11cd20fc7df05362b
Gitweb:        https://git.kernel.org/tip/3548eda8ae284d6d412d59f11cd20fc7df05362b
Author:        Chen Lifu <chenlifu@huawei.com>
AuthorDate:    Tue, 23 Aug 2022 10:18:21 +08:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Mon, 17 Oct 2022 16:20:48 +02:00

x86/tsc: Make art_related_clocksource static

The symbol is not used outside of the file, so mark it static.

Fixes the following warning:

arch/x86/kernel/tsc.c:53:20: warning:
	symbol 'art_related_clocksource' was not declared. Should it be static?

Signed-off-by: Chen Lifu <chenlifu@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20220823021821.3052159-1-chenlifu@huawei.com

---
 arch/x86/kernel/tsc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index cafacb2..a78e73d 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -51,7 +51,7 @@ int tsc_clocksource_reliable;
 static u32 art_to_tsc_numerator;
 static u32 art_to_tsc_denominator;
 static u64 art_to_tsc_offset;
-struct clocksource *art_related_clocksource;
+static struct clocksource *art_related_clocksource;
 
 struct cyc2ns {
 	struct cyc2ns_data data[2];	/*  0 + 2*16 = 32 */