[v1] EDAC/mc/synopsys: Various fixes and cleanups

[PATCH 13/20] EDAC/mc: Drop duplicated dimm->nr_pages debug printout

Posted by Serge Semin 3 years, 7 months ago

The duplicated edac_dbg()-based dimm->nr_pages field was introduced in
commit 6e84d359b2be ("edac_mc: Cleanup per-dimm_info debug messages"). You
can find the duplicated line even in the commit message text:
> [ 1011.380101] EDAC DEBUG: edac_mc_dump_dimm:   dimm->nr_pages = 0x40000
> [ 1011.380103] EDAC DEBUG: edac_mc_dump_dimm:   dimm->grain = 8
> [ 1011.380104] EDAC DEBUG: edac_mc_dump_dimm:   dimm->nr_pages = 0x40000
Let's drop the corresponding edac_dbg() method call then.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
 drivers/edac/edac_mc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
index eb58644bb019..6faeb2ab3960 100644
--- a/drivers/edac/edac_mc.c
+++ b/drivers/edac/edac_mc.c
@@ -103,7 +103,6 @@ static void edac_mc_dump_dimm(struct dimm_info *dimm)
 	edac_dbg(4, "  dimm->label = '%s'\n", dimm->label);
 	edac_dbg(4, "  dimm->nr_pages = 0x%x\n", dimm->nr_pages);
 	edac_dbg(4, "  dimm->grain = %d\n", dimm->grain);
-	edac_dbg(4, "  dimm->nr_pages = 0x%x\n", dimm->nr_pages);
 }
 
 static void edac_mc_dump_csrow(struct csrow_info *csrow)
-- 
2.35.1

Re: [PATCH 13/20] EDAC/mc: Drop duplicated dimm->nr_pages debug printout

Posted by Borislav Petkov 3 years, 7 months ago

On Mon, Aug 22, 2022 at 10:07:23PM +0300, Serge Semin wrote:
> The duplicated edac_dbg()-based dimm->nr_pages field was introduced in
> commit 6e84d359b2be ("edac_mc: Cleanup per-dimm_info debug messages"). You
> can find the duplicated line even in the commit message text:
> > [ 1011.380101] EDAC DEBUG: edac_mc_dump_dimm:   dimm->nr_pages = 0x40000
> > [ 1011.380103] EDAC DEBUG: edac_mc_dump_dimm:   dimm->grain = 8
> > [ 1011.380104] EDAC DEBUG: edac_mc_dump_dimm:   dimm->nr_pages = 0x40000
> Let's drop the corresponding edac_dbg() method call then.
> 
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> ---
>  drivers/edac/edac_mc.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette