[PATCH] power/acpi: Remove unnecessary return in acpi_os_** function;

Li zeming posted 1 patch 3 years, 7 months ago
tools/power/acpi/os_specific/service_layers/osunixxf.c | 3 ---
1 file changed, 3 deletions(-)
[PATCH] power/acpi: Remove unnecessary return in acpi_os_** function;
Posted by Li zeming 3 years, 7 months ago
Remove the return in the function; it looks clearer.

Signed-off-by: Li zeming <zeming@nfschina.com>
---
 tools/power/acpi/os_specific/service_layers/osunixxf.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tools/power/acpi/os_specific/service_layers/osunixxf.c b/tools/power/acpi/os_specific/service_layers/osunixxf.c
index b3651a04d68c..127630c38f1a 100644
--- a/tools/power/acpi/os_specific/service_layers/osunixxf.c
+++ b/tools/power/acpi/os_specific/service_layers/osunixxf.c
@@ -510,8 +510,6 @@ void *acpi_os_map_memory(acpi_physical_address where, acpi_size length)
 
 void acpi_os_unmap_memory(void *where, acpi_size length)
 {
-
-	return;
 }
 #endif
 
@@ -1313,5 +1311,4 @@ acpi_os_execute(acpi_execute_type type,
 
 void acpi_os_wait_events_complete(void)
 {
-	return;
 }
-- 
2.18.2
Re: [PATCH] power/acpi: Remove unnecessary return in acpi_os_** function;
Posted by Rafael J. Wysocki 3 years, 7 months ago
On Mon, Aug 22, 2022 at 11:16 AM Li zeming <zeming@nfschina.com> wrote:
>
> Remove the return in the function; it looks clearer.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>

This is ACPICA code, so please submit changes against it to the
upstream ACPICA project on GitHub.  Thanks!

> ---
>  tools/power/acpi/os_specific/service_layers/osunixxf.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/tools/power/acpi/os_specific/service_layers/osunixxf.c b/tools/power/acpi/os_specific/service_layers/osunixxf.c
> index b3651a04d68c..127630c38f1a 100644
> --- a/tools/power/acpi/os_specific/service_layers/osunixxf.c
> +++ b/tools/power/acpi/os_specific/service_layers/osunixxf.c
> @@ -510,8 +510,6 @@ void *acpi_os_map_memory(acpi_physical_address where, acpi_size length)
>
>  void acpi_os_unmap_memory(void *where, acpi_size length)
>  {
> -
> -       return;
>  }
>  #endif
>
> @@ -1313,5 +1311,4 @@ acpi_os_execute(acpi_execute_type type,
>
>  void acpi_os_wait_events_complete(void)
>  {
> -       return;
>  }
> --
> 2.18.2
>