arm64: dts: imx8mp-verdin: add cpu-supply

[PATCH] arm64: dts: imx8mp-verdin: add cpu-supply

Posted by Max Krummenacher 3 years, 7 months ago

From: Max Krummenacher <max.krummenacher@toradex.com>

Add the cpu-supply property to all CPU nodes to enable the cpufreq
driver.

Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

---

 .../boot/dts/freescale/imx8mp-verdin.dtsi      | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
index f062fdbb2719..dbc22b672fb3 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
@@ -146,6 +146,22 @@ reserved-memory {
 	};
 };
 
+&A53_0 {
+	cpu-supply = <&reg_vdd_arm>;
+};
+
+&A53_1 {
+	cpu-supply = <&reg_vdd_arm>;
+};
+
+&A53_2 {
+	cpu-supply = <&reg_vdd_arm>;
+};
+
+&A53_3 {
+	cpu-supply = <&reg_vdd_arm>;
+};
+
 &cpu_alert0 {
 	temperature = <95000>;
 };
@@ -453,7 +469,7 @@ BUCK1 {
 				regulator-ramp-delay = <3125>;
 			};
 
-			BUCK2 {
+			reg_vdd_arm: BUCK2 {
 				nxp,dvs-run-voltage = <950000>;
 				nxp,dvs-standby-voltage = <850000>;
 				regulator-always-on;
-- 
2.35.3

Re: [PATCH] arm64: dts: imx8mp-verdin: add cpu-supply

Posted by Shawn Guo 3 years, 7 months ago

On Mon, Aug 22, 2022 at 09:53:42AM +0200, Max Krummenacher wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> Add the cpu-supply property to all CPU nodes to enable the cpufreq
> driver.
> 
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

Applied, thanks!

Re: [PATCH] arm64: dts: imx8mp-verdin: add cpu-supply

Posted by Francesco Dolcini 3 years, 7 months ago

On Mon, Aug 22, 2022 at 09:53:42AM +0200, Max Krummenacher wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> Add the cpu-supply property to all CPU nodes to enable the cpufreq
> driver.
> 
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

This would need a fixes tag IMO:

Fixes: a39ed23bdf6e ("arm64: dts: freescale: add initial support for verdin imx8m plus")

Francesco

Re: [PATCH] arm64: dts: imx8mp-verdin: add cpu-supply

Posted by Marcel Ziswiler 3 years, 7 months ago

On Mon, 2022-08-22 at 09:53 +0200, Max Krummenacher wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> Add the cpu-supply property to all CPU nodes to enable the cpufreq
> driver.
> 
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

> ---
> 
>  .../boot/dts/freescale/imx8mp-verdin.dtsi      | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-
> verdin.dtsi
> index f062fdbb2719..dbc22b672fb3 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -146,6 +146,22 @@ reserved-memory {
>         };
>  };
>  
> +&A53_0 {
> +       cpu-supply = <&reg_vdd_arm>;
> +};
> +
> +&A53_1 {
> +       cpu-supply = <&reg_vdd_arm>;
> +};
> +
> +&A53_2 {
> +       cpu-supply = <&reg_vdd_arm>;
> +};
> +
> +&A53_3 {
> +       cpu-supply = <&reg_vdd_arm>;
> +};
> +
>  &cpu_alert0 {
>         temperature = <95000>;
>  };
> @@ -453,7 +469,7 @@ BUCK1 {
>                                 regulator-ramp-delay = <3125>;
>                         };
>  
> -                       BUCK2 {
> +                       reg_vdd_arm: BUCK2 {
>                                 nxp,dvs-run-voltage = <950000>;
>                                 nxp,dvs-standby-voltage = <850000>;
>                                 regulator-always-on;

Re: [PATCH] arm64: dts: imx8mp-verdin: add cpu-supply

Posted by Laurent Pinchart 3 years, 7 months ago

Hi Max,

Thank you for the patch.

On Mon, Aug 22, 2022 at 09:53:42AM +0200, Max Krummenacher wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
> 
> Add the cpu-supply property to all CPU nodes to enable the cpufreq
> driver.
> 
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
>  .../boot/dts/freescale/imx8mp-verdin.dtsi      | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> index f062fdbb2719..dbc22b672fb3 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -146,6 +146,22 @@ reserved-memory {
>  	};
>  };
>  
> +&A53_0 {
> +	cpu-supply = <&reg_vdd_arm>;
> +};
> +
> +&A53_1 {
> +	cpu-supply = <&reg_vdd_arm>;
> +};
> +
> +&A53_2 {
> +	cpu-supply = <&reg_vdd_arm>;
> +};
> +
> +&A53_3 {
> +	cpu-supply = <&reg_vdd_arm>;
> +};
> +
>  &cpu_alert0 {
>  	temperature = <95000>;
>  };
> @@ -453,7 +469,7 @@ BUCK1 {
>  				regulator-ramp-delay = <3125>;
>  			};
>  
> -			BUCK2 {
> +			reg_vdd_arm: BUCK2 {
>  				nxp,dvs-run-voltage = <950000>;
>  				nxp,dvs-standby-voltage = <850000>;
>  				regulator-always-on;

-- 
Regards,

Laurent Pinchart