Hi Steven,

Thanks for your comments. We have fixed the patches according to them.

You wrote the first patch is r-b, but I took the liberty to add your r-b to
all three patches, I hope you don't object.

Thanks,
Oded

Ohad Sharabi (3):
  habanalabs: define trace events
  habanalabs: trace MMU map/unmap page
  habanalabs: trace DMA allocations

 MAINTAINERS                                   |  1 +
 drivers/misc/habanalabs/common/device.c       | 49 ++++++----
 drivers/misc/habanalabs/common/habanalabs.h   | 40 ++++++--
 .../misc/habanalabs/common/habanalabs_drv.c   |  3 +
 drivers/misc/habanalabs/common/mmu/mmu.c      |  7 ++
 include/trace/events/habanalabs.h             | 93 +++++++++++++++++++
 6 files changed, 166 insertions(+), 27 deletions(-)
 create mode 100644 include/trace/events/habanalabs.h

-- 
2.25.1

On Sun, 21 Aug 2022 11:06:05 +0300
Oded Gabbay <ogabbay@kernel.org> wrote:

> Thanks for your comments. We have fixed the patches according to them.
> 
> You wrote the first patch is r-b, but I took the liberty to add your r-b to
> all three patches, I hope you don't object.

I usually only add the r-b to the patches that add TRACE_EVENT(), and
sometimes to those that modify them. Because that's what I know best. The
usage of the trace events is usually subsystem specific and I tend not to
add a r-b for them because people might think I understand how they are
being used ;-)

But in this case, since I did recommend some tricks in those extra patches,
you can keep the tag for them.

Here's my disclaimer for all these patches:

***

Reviewed only from the tracing point of view, I have no idea if the content
held in the trace is correct or not.

***

;-)

-- Steve

On Mon, Aug 22, 2022 at 5:52 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Sun, 21 Aug 2022 11:06:05 +0300
> Oded Gabbay <ogabbay@kernel.org> wrote:
>
> > Thanks for your comments. We have fixed the patches according to them.
> >
> > You wrote the first patch is r-b, but I took the liberty to add your r-b to
> > all three patches, I hope you don't object.
>
> I usually only add the r-b to the patches that add TRACE_EVENT(), and
> sometimes to those that modify them. Because that's what I know best. The
> usage of the trace events is usually subsystem specific and I tend not to
> add a r-b for them because people might think I understand how they are
> being used ;-)
>
> But in this case, since I did recommend some tricks in those extra patches,
> you can keep the tag for them.
>
> Here's my disclaimer for all these patches:
>
> ***
>
> Reviewed only from the tracing point of view, I have no idea if the content
> held in the trace is correct or not.
>
> ***
>
> ;-)
>
> -- Steve

Disclaimer duly noted Steve ;-)
Thanks for the review.

Oded