1. Patchew
  2. linux
  3. [PATCH 0/7] powerpc/85xx: p2020: Create one unified machine description
  4. View patch

[PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() as static

Pali Rohár posted 7 patches 3 years, 7 months ago
There is a newer version of this series
[PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() as static
Posted by Pali Rohár 3 years, 7 months ago 
Function mpc85xx_ds_pic_init() is not used out of the mpc85xx_ds.c file.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 arch/powerpc/platforms/85xx/mpc85xx_ds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
index f8d2c97f39bd..9a6d637ef54a 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_ds.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
@@ -54,7 +54,7 @@ static void mpc85xx_8259_cascade(struct irq_desc *desc)
 }
 #endif	/* CONFIG_PPC_I8259 */
 
-void __init mpc85xx_ds_pic_init(void)
+static void __init mpc85xx_ds_pic_init(void)
 {
 	struct mpic *mpic;
 #ifdef CONFIG_PPC_I8259
-- 
2.20.1
Re: [PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() as static
Posted by Christophe Leroy 3 years, 6 months ago 

Le 19/08/2022 à 21:15, Pali Rohár a écrit :
> Function mpc85xx_ds_pic_init() is not used out of the mpc85xx_ds.c file.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>

This patch should be squashed into patch 1.

> ---
>   arch/powerpc/platforms/85xx/mpc85xx_ds.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> index f8d2c97f39bd..9a6d637ef54a 100644
> --- a/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> +++ b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> @@ -54,7 +54,7 @@ static void mpc85xx_8259_cascade(struct irq_desc *desc)
>   }
>   #endif	/* CONFIG_PPC_I8259 */
>   
> -void __init mpc85xx_ds_pic_init(void)
> +static void __init mpc85xx_ds_pic_init(void)
>   {
>   	struct mpic *mpic;
>   #ifdef CONFIG_PPC_I8259
Re: [PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() as static
Posted by Pali Rohár 3 years, 6 months ago 
On Monday 26 September 2022 09:43:55 Christophe Leroy wrote:
> Le 19/08/2022 à 21:15, Pali Rohár a écrit :
> > Function mpc85xx_ds_pic_init() is not used out of the mpc85xx_ds.c file.
> > 
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> 
> This patch should be squashed into patch 1.

No problem. Just to explain that I split those changes into different
patches because they touch different files and different board code.
And I thought that different things should be in different patches.

> > ---
> >   arch/powerpc/platforms/85xx/mpc85xx_ds.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> > index f8d2c97f39bd..9a6d637ef54a 100644
> > --- a/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> > +++ b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> > @@ -54,7 +54,7 @@ static void mpc85xx_8259_cascade(struct irq_desc *desc)
> >   }
> >   #endif	/* CONFIG_PPC_I8259 */
> >   
> > -void __init mpc85xx_ds_pic_init(void)
> > +static void __init mpc85xx_ds_pic_init(void)
> >   {
> >   	struct mpic *mpic;
> >   #ifdef CONFIG_PPC_I8259
Re: [PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() as static
Posted by Pali Rohár 3 years, 5 months ago 
Hello Christophe! Do you have any other comments for this patch series?

On Monday 26 September 2022 11:47:06 Pali Rohár wrote:
> On Monday 26 September 2022 09:43:55 Christophe Leroy wrote:
> > Le 19/08/2022 à 21:15, Pali Rohár a écrit :
> > > Function mpc85xx_ds_pic_init() is not used out of the mpc85xx_ds.c file.
> > > 
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > 
> > This patch should be squashed into patch 1.
> 
> No problem. Just to explain that I split those changes into different
> patches because they touch different files and different board code.
> And I thought that different things should be in different patches.
> 
> > > ---
> > >   arch/powerpc/platforms/85xx/mpc85xx_ds.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> > > index f8d2c97f39bd..9a6d637ef54a 100644
> > > --- a/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> > > +++ b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> > > @@ -54,7 +54,7 @@ static void mpc85xx_8259_cascade(struct irq_desc *desc)
> > >   }
> > >   #endif	/* CONFIG_PPC_I8259 */
> > >   
> > > -void __init mpc85xx_ds_pic_init(void)
> > > +static void __init mpc85xx_ds_pic_init(void)
> > >   {
> > >   	struct mpic *mpic;
> > >   #ifdef CONFIG_PPC_I8259
Re: [PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() as static
Posted by Christophe Leroy 3 years, 5 months ago 
Hello,

Le 16/10/2022 à 13:05, Pali Rohár a écrit :
> Hello Christophe! Do you have any other comments for this patch series?

I'm AFK for two weeks, but as far as I remember I don't have any more 
comments.

> 
> On Monday 26 September 2022 11:47:06 Pali Rohár wrote:
>> On Monday 26 September 2022 09:43:55 Christophe Leroy wrote:
>>> Le 19/08/2022 à 21:15, Pali Rohár a écrit :
>>>> Function mpc85xx_ds_pic_init() is not used out of the mpc85xx_ds.c file.
>>>>
>>>> Signed-off-by: Pali Rohár <pali@kernel.org>
>>>
>>> This patch should be squashed into patch 1.
>>
>> No problem. Just to explain that I split those changes into different
>> patches because they touch different files and different board code.
>> And I thought that different things should be in different patches.
>>
>>>> ---
>>>>    arch/powerpc/platforms/85xx/mpc85xx_ds.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
>>>> index f8d2c97f39bd..9a6d637ef54a 100644
>>>> --- a/arch/powerpc/platforms/85xx/mpc85xx_ds.c
>>>> +++ b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
>>>> @@ -54,7 +54,7 @@ static void mpc85xx_8259_cascade(struct irq_desc *desc)
>>>>    }
>>>>    #endif	/* CONFIG_PPC_I8259 */
>>>>    
>>>> -void __init mpc85xx_ds_pic_init(void)
>>>> +static void __init mpc85xx_ds_pic_init(void)
>>>>    {
>>>>    	struct mpic *mpic;
>>>>    #ifdef CONFIG_PPC_I8259
Re: [PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() as static
Posted by Pali Rohár 3 years, 5 months ago 
On Sunday 16 October 2022 16:59:53 Christophe Leroy wrote:
> Hello,
> 
> Le 16/10/2022 à 13:05, Pali Rohár a écrit :
> > Hello Christophe! Do you have any other comments for this patch series?
> 
> I'm AFK for two weeks, but as far as I remember I don't have any more 
> comments.

Hello! When you are back, could you look at my feedback to your comments?

> > 
> > On Monday 26 September 2022 11:47:06 Pali Rohár wrote:
> >> On Monday 26 September 2022 09:43:55 Christophe Leroy wrote:
> >>> Le 19/08/2022 à 21:15, Pali Rohár a écrit :
> >>>> Function mpc85xx_ds_pic_init() is not used out of the mpc85xx_ds.c file.
> >>>>
> >>>> Signed-off-by: Pali Rohár <pali@kernel.org>
> >>>
> >>> This patch should be squashed into patch 1.
> >>
> >> No problem. Just to explain that I split those changes into different
> >> patches because they touch different files and different board code.
> >> And I thought that different things should be in different patches.
> >>
> >>>> ---
> >>>>    arch/powerpc/platforms/85xx/mpc85xx_ds.c | 2 +-
> >>>>    1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> >>>> index f8d2c97f39bd..9a6d637ef54a 100644
> >>>> --- a/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> >>>> +++ b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> >>>> @@ -54,7 +54,7 @@ static void mpc85xx_8259_cascade(struct irq_desc *desc)
> >>>>    }
> >>>>    #endif	/* CONFIG_PPC_I8259 */
> >>>>    
> >>>> -void __init mpc85xx_ds_pic_init(void)
> >>>> +static void __init mpc85xx_ds_pic_init(void)
> >>>>    {
> >>>>    	struct mpic *mpic;
> >>>>    #ifdef CONFIG_PPC_I8259
Re: [PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() as static
Posted by Pali Rohár 3 years, 4 months ago 
On Wednesday 02 November 2022 00:25:03 Pali Rohár wrote:
> On Sunday 16 October 2022 16:59:53 Christophe Leroy wrote:
> > Hello,
> > 
> > Le 16/10/2022 à 13:05, Pali Rohár a écrit :
> > > Hello Christophe! Do you have any other comments for this patch series?
> > 
> > I'm AFK for two weeks, but as far as I remember I don't have any more 
> > comments.
> 
> Hello! When you are back, could you look at my feedback to your comments?

PING?

> > > 
> > > On Monday 26 September 2022 11:47:06 Pali Rohár wrote:
> > >> On Monday 26 September 2022 09:43:55 Christophe Leroy wrote:
> > >>> Le 19/08/2022 à 21:15, Pali Rohár a écrit :
> > >>>> Function mpc85xx_ds_pic_init() is not used out of the mpc85xx_ds.c file.
> > >>>>
> > >>>> Signed-off-by: Pali Rohár <pali@kernel.org>
> > >>>
> > >>> This patch should be squashed into patch 1.
> > >>
> > >> No problem. Just to explain that I split those changes into different
> > >> patches because they touch different files and different board code.
> > >> And I thought that different things should be in different patches.
> > >>
> > >>>> ---
> > >>>>    arch/powerpc/platforms/85xx/mpc85xx_ds.c | 2 +-
> > >>>>    1 file changed, 1 insertion(+), 1 deletion(-)
> > >>>>
> > >>>> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> > >>>> index f8d2c97f39bd..9a6d637ef54a 100644
> > >>>> --- a/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> > >>>> +++ b/arch/powerpc/platforms/85xx/mpc85xx_ds.c
> > >>>> @@ -54,7 +54,7 @@ static void mpc85xx_8259_cascade(struct irq_desc *desc)
> > >>>>    }
> > >>>>    #endif	/* CONFIG_PPC_I8259 */
> > >>>>    
> > >>>> -void __init mpc85xx_ds_pic_init(void)
> > >>>> +static void __init mpc85xx_ds_pic_init(void)
> > >>>>    {
> > >>>>    	struct mpic *mpic;
> > >>>>    #ifdef CONFIG_PPC_I8259
Re: [PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() as static
Posted by Christophe Leroy 3 years, 4 months ago 

Le 26/11/2022 à 17:25, Pali Rohár a écrit :
> On Wednesday 02 November 2022 00:25:03 Pali Rohár wrote:
>> On Sunday 16 October 2022 16:59:53 Christophe Leroy wrote:
>>> Hello,
>>>
>>> Le 16/10/2022 à 13:05, Pali Rohár a écrit :
>>>> Hello Christophe! Do you have any other comments for this patch series?
>>>
>>> I'm AFK for two weeks, but as far as I remember I don't have any more
>>> comments.
>>
>> Hello! When you are back, could you look at my feedback to your comments?
> 
> PING?
> 
>>>>
>>>> On Monday 26 September 2022 11:47:06 Pali Rohár wrote:
>>>>> On Monday 26 September 2022 09:43:55 Christophe Leroy wrote:
>>>>>> Le 19/08/2022 à 21:15, Pali Rohár a écrit :
>>>>>>> Function mpc85xx_ds_pic_init() is not used out of the mpc85xx_ds.c file.
>>>>>>>
>>>>>>> Signed-off-by: Pali Rohár <pali@kernel.org>
>>>>>>
>>>>>> This patch should be squashed into patch 1.
>>>>>
>>>>> No problem. Just to explain that I split those changes into different
>>>>> patches because they touch different files and different board code.
>>>>> And I thought that different things should be in different patches.

It's fine for me if you prefer keeping them separate, up to you.

Christophe

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.