[PATCH 5.15 00/14] 5.15.62-rc1 review

Greg Kroah-Hartman posted 14 patches 3 years, 7 months ago
Makefile                          |   4 +-
arch/arm64/include/asm/kexec.h    |   4 +-
arch/arm64/kernel/kexec_image.c   |  11 +---
arch/powerpc/include/asm/kexec.h  |   9 +++
arch/s390/include/asm/kexec.h     |   3 +
arch/x86/include/asm/kexec.h      |   6 ++
arch/x86/kernel/ftrace.c          |   7 +-
arch/x86/kernel/ftrace_64.S       |  19 ++++--
arch/x86/kernel/kexec-bzimage64.c |  20 +-----
drivers/tee/tee_shm.c             |   3 +
fs/btrfs/raid56.c                 |  74 +++++++++++++++++-----
fs/io_uring.c                     |   2 +-
fs/ksmbd/smb2misc.c               |   7 +-
fs/ksmbd/smb2pdu.c                |  45 +++++++------
fs/ksmbd/smbacl.c                 | 130 ++++++++++++++++++++++++++------------
fs/ksmbd/smbacl.h                 |   2 +-
fs/ksmbd/vfs.c                    |   5 ++
include/linux/kexec.h             |  50 ++++++++++++---
kernel/kexec_file.c               |  83 +++++++++---------------
net/sched/cls_route.c             |  10 +++
20 files changed, 312 insertions(+), 182 deletions(-)
[PATCH 5.15 00/14] 5.15.62-rc1 review
Posted by Greg Kroah-Hartman 3 years, 7 months ago
This is the start of the stable review cycle for the 5.15.62 release.
There are 14 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.

Responses should be made by Sun, 21 Aug 2022 15:36:59 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.62-rc1.gz
or in the git tree and branch at:
	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Linux 5.15.62-rc1

Coiby Xu <coxu@redhat.com>
    arm64: kexec_file: use more system keyrings to verify kernel image signature

Coiby Xu <coxu@redhat.com>
    kexec, KEYS: make the code in bzImage64_verify_sig generic

Coiby Xu <coxu@redhat.com>
    kexec: clean up arch_kexec_kernel_verify_sig

Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
    kexec_file: drop weak attribute from functions

Qu Wenruo <wqu@suse.com>
    btrfs: raid56: don't trust any cached sector in __raid56_parity_recover()

Qu Wenruo <wqu@suse.com>
    btrfs: only write the sectors in the vertical stripe which has data stripes

Peter Zijlstra <peterz@infradead.org>
    x86/ftrace: Use alternative RET encoding

Peter Zijlstra <peterz@infradead.org>
    x86/ibt,ftrace: Make function-graph play nice

Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
    Revert "x86/ftrace: Use alternative RET encoding"

Namjae Jeon <linkinjeon@kernel.org>
    ksmbd: fix heap-based overflow in set_ntacl_dacl()

Hyunchul Lee <hyc.lee@gmail.com>
    ksmbd: prevent out of bound read for SMB2_WRITE

Jamal Hadi Salim <jhs@mojatatu.com>
    net_sched: cls_route: disallow handle of 0

Jens Wiklander <jens.wiklander@linaro.org>
    tee: add overflow check in register_shm_helper()

Jens Axboe <axboe@kernel.dk>
    io_uring: use original request task for inflight tracking


-------------

Diffstat:

 Makefile                          |   4 +-
 arch/arm64/include/asm/kexec.h    |   4 +-
 arch/arm64/kernel/kexec_image.c   |  11 +---
 arch/powerpc/include/asm/kexec.h  |   9 +++
 arch/s390/include/asm/kexec.h     |   3 +
 arch/x86/include/asm/kexec.h      |   6 ++
 arch/x86/kernel/ftrace.c          |   7 +-
 arch/x86/kernel/ftrace_64.S       |  19 ++++--
 arch/x86/kernel/kexec-bzimage64.c |  20 +-----
 drivers/tee/tee_shm.c             |   3 +
 fs/btrfs/raid56.c                 |  74 +++++++++++++++++-----
 fs/io_uring.c                     |   2 +-
 fs/ksmbd/smb2misc.c               |   7 +-
 fs/ksmbd/smb2pdu.c                |  45 +++++++------
 fs/ksmbd/smbacl.c                 | 130 ++++++++++++++++++++++++++------------
 fs/ksmbd/smbacl.h                 |   2 +-
 fs/ksmbd/vfs.c                    |   5 ++
 include/linux/kexec.h             |  50 ++++++++++++---
 kernel/kexec_file.c               |  83 +++++++++---------------
 net/sched/cls_route.c             |  10 +++
 20 files changed, 312 insertions(+), 182 deletions(-)
Re: [PATCH 5.15 00/14] 5.15.62-rc1 review
Posted by Guenter Roeck 3 years, 7 months ago
On Fri, Aug 19, 2022 at 05:40:16PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.62 release.
> There are 14 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sun, 21 Aug 2022 15:36:59 +0000.
> Anything received after that time might be too late.
> 

Build results:
	total: 159 pass: 157 fail: 2
Failed builds:
	s390:defconfig
	s390:allmodconfig
Qemu test results:
	total: 470 pass: 465 fail: 5
Failed tests:
	s390:defconfig:nolocktests:smp2:net,default:initrd
	s390:defconfig:nolocktests:smp2:virtio-blk-ccw:net,virtio-net-pci:rootfs
	s390:defconfig:nolocktests:smp2:scsi[virtio-ccw]:net,default:rootfs
	s390:defconfig:nolocktests:virtio-pci:net,virtio-net-pci:rootfs
	s390:defconfig:nolocktests:scsi[virtio-pci]:net,default:rootfs

This has been reported already, so I won't go into details.

Note that I did not get this e-mail, even though I am listed in Cc:.
I had to copy it from lore.kernel.org/stable.

Guenter
Re: [PATCH 5.15 00/14] 5.15.62-rc1 review
Posted by Ron Economos 3 years, 7 months ago
On 8/19/22 8:40 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.62 release.
> There are 14 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 21 Aug 2022 15:36:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.62-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Built and booted successfully on RISC-V RV64 (HiFive Unmatched).

Tested-by: Ron Economos <re@w6rz.net>
Re: [PATCH 5.15 00/14] 5.15.62-rc1 review
Posted by Sudip Mukherjee (Codethink) 3 years, 7 months ago
Hi Greg,

On Fri, Aug 19, 2022 at 05:40:16PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.62 release.
> There are 14 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sun, 21 Aug 2022 15:36:59 +0000.
> Anything received after that time might be too late.

Build test (gcc version 11.3.1 20220819):
mips: 62 configs -> no failure
arm: 99 configs -> no failure
arm64: 3 configs -> no failure
x86_64: 4 configs -> no failure
alpha allmodconfig -> no failure
csky allmodconfig -> no failure
powerpc allmodconfig -> no failure
riscv allmodconfig -> no failure
s390 allmodconfig -> fails
xtensa allmodconfig -> no failure

Note:

s390 allmodconfig fails with:

arch/s390/kernel/machine_kexec_file.c:336:5: error: redefinition of 'arch_kexec_kernel_image_probe'
  336 | int arch_kexec_kernel_image_probe(struct kimage *image, void *buf,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from arch/s390/kernel/machine_kexec_file.c:12:
./include/linux/kexec.h:190:1: note: previous definition of 'arch_kexec_kernel_image_probe' with type 'int(struct kimage *, void *, long unsigned int)'
  190 | arch_kexec_kernel_image_probe(struct kimage *image, void *buf, unsigned long buf_len)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by: 4dc6d49023a0 ("kexec_file: drop weak attribute from functions")


Boot test:
x86_64: Booted on my test laptop. No regression.
x86_64: Booted on qemu. No regression. [1]
mips: Booted on ci20 board. No regression. [2]

[1]. https://openqa.qa.codethink.co.uk/tests/1659
[2]. https://openqa.qa.codethink.co.uk/tests/1666

Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

--
Regards
Sudip
Re: [PATCH 5.15 00/14] 5.15.62-rc1 review
Posted by Bagas Sanjaya 3 years, 7 months ago
On Fri, Aug 19, 2022 at 05:40:16PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.62 release.
> There are 14 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 

Successfully cross-compiled for arm64 (bcm2711_defconfig, GCC 10.2.0) and
powerpc (ps3_defconfig, GCC 12.1.0).

Tested-by: Bagas Sanjaya <bagasdotme@gmail.com>

-- 
An old man doll... just what I always wanted! - Clara
Re: [PATCH 5.15 00/14] 5.15.62-rc1 review
Posted by Naresh Kamboju 3 years, 7 months ago
On Fri, 19 Aug 2022 at 21:11, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.15.62 release.
> There are 14 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 21 Aug 2022 15:36:59 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.62-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Results from Linaro's test farm.
Following regression found on s390.

> Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
>     kexec_file: drop weak attribute from functions

The s390 defconfig build failed on stable-rc 5.15 with gcc-11 and clang.


arch/s390/kernel/machine_kexec_file.c:336:5: error: redefinition of
'arch_kexec_kernel_image_probe'
int arch_kexec_kernel_image_probe(struct kimage *image, void *buf,
    ^
include/linux/kexec.h:190:1: note: previous definition is here
arch_kexec_kernel_image_probe(struct kimage *image, void *buf,
unsigned long buf_len)
^
1 error generated.


## Build
* kernel: 5.15.62-rc1
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-5.15.y
* git commit: b79f9f8ea7ab2be6f724e8cde6db2a3fb057f62e
* git describe: v5.15.61-15-gb79f9f8ea7ab
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15.61-15-gb79f9f8ea7ab

## Test Regressions (compared to v5.15.61)

* s390, build
  - clang-13-defconfig
  - clang-14-defconfig
  - clang-nightly-defconfig
  - gcc-10-defconfig
  - gcc-11-defconfig
  - gcc-9-defconfig

## No metric Regressions (compared to v5.15.61)

## No test Fixes (compared to v5.15.61)

## No metric Fixes (compared to v5.15.61)

## Test result summary
total: 140859, pass: 124026, fail: 701, skip: 15336, xfail: 796

## Build Summary
* arc: 10 total, 10 passed, 0 failed
* arm: 314 total, 311 passed, 3 failed
* arm64: 77 total, 75 passed, 2 failed
* i386: 65 total, 59 passed, 6 failed
* mips: 50 total, 47 passed, 3 failed
* parisc: 14 total, 14 passed, 0 failed
* powerpc: 59 total, 56 passed, 3 failed
* riscv: 27 total, 27 passed, 0 failed
* s390: 26 total, 14 passed, 12 failed
* sh: 26 total, 24 passed, 2 failed
* sparc: 14 total, 14 passed, 0 failed
* x86_64: 70 total, 68 passed, 2 failed

## Test suites summary
* fwts
* igt-gpu-tools
* kunit
* kvm-unit-tests
* libgpiod
* libhugetlbfs
* log-parser-boot
* log-parser-test
* ltp-cap_bounds
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-fsx
* ltp-hugetlb
* ltp-io
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-open-posix-tests
* ltp-pty
* ltp-sched
* ltp-securebits
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* network-basic-tests
* packetdrill
* rcutorture
* ssuite
* v4l2-compliance
* vdso

--
Linaro LKFT
https://lkft.linaro.org
Re: [PATCH 5.15 00/14] 5.15.62-rc1 review
Posted by Greg Kroah-Hartman 3 years, 7 months ago
On Sat, Aug 20, 2022 at 01:57:05PM +0530, Naresh Kamboju wrote:
> On Fri, 19 Aug 2022 at 21:11, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > This is the start of the stable review cycle for the 5.15.62 release.
> > There are 14 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sun, 21 Aug 2022 15:36:59 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.62-rc1.gz
> > or in the git tree and branch at:
> >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> 
> Results from Linaro's test farm.
> Following regression found on s390.
> 
> > Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> >     kexec_file: drop weak attribute from functions
> 
> The s390 defconfig build failed on stable-rc 5.15 with gcc-11 and clang.
> 
> 
> arch/s390/kernel/machine_kexec_file.c:336:5: error: redefinition of
> 'arch_kexec_kernel_image_probe'
> int arch_kexec_kernel_image_probe(struct kimage *image, void *buf,
>     ^
> include/linux/kexec.h:190:1: note: previous definition is here
> arch_kexec_kernel_image_probe(struct kimage *image, void *buf,
> unsigned long buf_len)
> ^
> 1 error generated.
> 

argh, these kexec patches are such a pain.  I'll go drop them from 5.15
now and push out a -rc2 that hopefully will fix this.

thanks,

greg k-h
Re: [PATCH 5.15 00/14] 5.15.62-rc1 review
Posted by Shuah Khan 3 years, 7 months ago
On 8/19/22 9:40 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.62 release.
> There are 14 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Sun, 21 Aug 2022 15:36:59 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.62-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 

Compiled and booted on my test system. No dmesg regressions.

Tested-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah