[v3] arm64: dts: qcom: improvements to TCSR mutex in DTS

[RFT PATCH v3 01/16] dt-bindings: mfd: qcom,tcsr: add several devices

Posted by Krzysztof Kozlowski 3 years, 7 months ago

Document existing (MSM8996, SC7280) and new compatibles for TCSR syscon
registers (QCS404, SC7180, SDM630, SDM845, SM8150, MSM8998).

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes since v2:
1. Add more compatibles.

Changes since v1:
1. Correct order of compatibles.
---
 Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
index 2f816fd0c9ec..d3c25daa995e 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
@@ -18,6 +18,13 @@ properties:
     oneOf:
       - items:
           - enum:
+              - qcom,msm8998-tcsr
+              - qcom,qcs404-tcsr
+              - qcom,sc7180-tcsr
+              - qcom,sc7280-tcsr
+              - qcom,sdm630-tcsr
+              - qcom,sdm845-tcsr
+              - qcom,sm8150-tcsr
               - qcom,tcsr-apq8064
               - qcom,tcsr-apq8084
               - qcom,tcsr-ipq8064
@@ -27,6 +34,7 @@ properties:
               - qcom,tcsr-msm8953
               - qcom,tcsr-msm8960
               - qcom,tcsr-msm8974
+              - qcom,tcsr-msm8996
           - const: syscon
       - items:
           - const: qcom,tcsr-ipq6018
-- 
2.34.1

Re: [RFT PATCH v3 01/16] dt-bindings: mfd: qcom,tcsr: add several devices

Posted by Lee Jones 3 years, 7 months ago

On Fri, 19 Aug 2022, Krzysztof Kozlowski wrote:

> Document existing (MSM8996, SC7280) and new compatibles for TCSR syscon
> registers (QCS404, SC7180, SDM630, SDM845, SM8150, MSM8998).
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Changes since v2:
> 1. Add more compatibles.
> 
> Changes since v1:
> 1. Correct order of compatibles.
> ---
>  Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]

Re: [RFT PATCH v3 01/16] dt-bindings: mfd: qcom,tcsr: add several devices

Posted by Lee Jones 3 years, 7 months ago

On Fri, 19 Aug 2022, Krzysztof Kozlowski wrote:

> Document existing (MSM8996, SC7280) and new compatibles for TCSR syscon
> registers (QCS404, SC7180, SDM630, SDM845, SM8150, MSM8998).
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

What does RFT mean?

> ---
> 
> Changes since v2:
> 1. Add more compatibles.
> 
> Changes since v1:
> 1. Correct order of compatibles.
> ---
>  Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> index 2f816fd0c9ec..d3c25daa995e 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> @@ -18,6 +18,13 @@ properties:
>      oneOf:
>        - items:
>            - enum:
> +              - qcom,msm8998-tcsr
> +              - qcom,qcs404-tcsr
> +              - qcom,sc7180-tcsr
> +              - qcom,sc7280-tcsr
> +              - qcom,sdm630-tcsr
> +              - qcom,sdm845-tcsr
> +              - qcom,sm8150-tcsr
>                - qcom,tcsr-apq8064
>                - qcom,tcsr-apq8084
>                - qcom,tcsr-ipq8064
> @@ -27,6 +34,7 @@ properties:
>                - qcom,tcsr-msm8953
>                - qcom,tcsr-msm8960
>                - qcom,tcsr-msm8974
> +              - qcom,tcsr-msm8996
>            - const: syscon
>        - items:
>            - const: qcom,tcsr-ipq6018

-- 
Lee Jones [李琼斯]

Re: [RFT PATCH v3 01/16] dt-bindings: mfd: qcom,tcsr: add several devices

Posted by Krzysztof Kozlowski 3 years, 7 months ago

On 05/09/2022 17:15, Lee Jones wrote:
> On Fri, 19 Aug 2022, Krzysztof Kozlowski wrote:
> 
>> Document existing (MSM8996, SC7280) and new compatibles for TCSR syscon
>> registers (QCS404, SC7180, SDM630, SDM845, SM8150, MSM8998).
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> What does RFT mean?

Request For Test, but I should be more specific: testing is welcomed for
DTS. Bindings were tested by me, but I just used one git format-patch
command.

I don't see blockers for this patch and Bjorn took DTS already.

Best regards,
Krzysztof

Re: [RFT PATCH v3 01/16] dt-bindings: mfd: qcom,tcsr: add several devices

Posted by Rob Herring 3 years, 7 months ago

On Fri, 19 Aug 2022 11:31:54 +0300, Krzysztof Kozlowski wrote:
> Document existing (MSM8996, SC7280) and new compatibles for TCSR syscon
> registers (QCS404, SC7180, SDM630, SDM845, SM8150, MSM8998).
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Changes since v2:
> 1. Add more compatibles.
> 
> Changes since v1:
> 1. Correct order of compatibles.
> ---
>  Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>