[PATCH 02/11] ARM: defconfig: clean up multi_v4t and multi_v5 configs

Arnd Bergmann posted 11 patches 3 years, 7 months ago
Only 2 patches received!
[PATCH 02/11] ARM: defconfig: clean up multi_v4t and multi_v5 configs
Posted by Arnd Bergmann 3 years, 7 months ago
From: Arnd Bergmann <arnd@arndb.de>

Integrator now selects the regulators and versatile selects the
reset driver, so the correspondig options can be dropped from
the defconfig files.

Fixes: d2854bbe5f5c ("ARM: integrator: Add some Kconfig selections")
Fixes: 1c6e288da6cc ("ARM: versatile: move restart to the device tree")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/configs/multi_v4t_defconfig | 2 --
 arch/arm/configs/multi_v5_defconfig  | 1 -
 2 files changed, 3 deletions(-)

diff --git a/arch/arm/configs/multi_v4t_defconfig b/arch/arm/configs/multi_v4t_defconfig
index 6c3e45b71ab5..e2fd822f741a 100644
--- a/arch/arm/configs/multi_v4t_defconfig
+++ b/arch/arm/configs/multi_v4t_defconfig
@@ -71,8 +71,6 @@ CONFIG_POWER_RESET_SYSCON_POWEROFF=y
 CONFIG_WATCHDOG=y
 CONFIG_GPIO_WATCHDOG=y
 CONFIG_AT91RM9200_WATCHDOG=y
-CONFIG_REGULATOR=y
-CONFIG_REGULATOR_FIXED_VOLTAGE=y
 CONFIG_REGULATOR_GPIO=y
 CONFIG_FB=y
 CONFIG_FB_CLPS711X=y
diff --git a/arch/arm/configs/multi_v5_defconfig b/arch/arm/configs/multi_v5_defconfig
index 5f3ed81228b0..a65f32a78885 100644
--- a/arch/arm/configs/multi_v5_defconfig
+++ b/arch/arm/configs/multi_v5_defconfig
@@ -149,7 +149,6 @@ CONFIG_SPI_SUN6I=y
 CONFIG_GPIO_ASPEED=m
 CONFIG_GPIO_ASPEED_SGPIO=y
 CONFIG_GPIO_MXC=y
-CONFIG_POWER_RESET=y
 CONFIG_POWER_RESET_GPIO=y
 CONFIG_POWER_RESET_QNAP=y
 CONFIG_SENSORS_ADT7475=y
-- 
2.29.2
Re: [PATCH 02/11] ARM: defconfig: clean up multi_v4t and multi_v5 configs
Posted by Linus Walleij 3 years, 7 months ago
On Thu, Aug 18, 2022 at 3:57 PM Arnd Bergmann <arnd@kernel.org> wrote:

> From: Arnd Bergmann <arnd@arndb.de>
>
> Integrator now selects the regulators and versatile selects the
> reset driver, so the correspondig options can be dropped from
> the defconfig files.
>
> Fixes: d2854bbe5f5c ("ARM: integrator: Add some Kconfig selections")
> Fixes: 1c6e288da6cc ("ARM: versatile: move restart to the device tree")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
[PATCH 03/11] ARM: defconfig: drop CONFIG_NET_VENDOR_ASIX=y
Posted by Arnd Bergmann 3 years, 7 months ago
From: Arnd Bergmann <arnd@arndb.de>

This option is 'default y' and has always been this way, the
line was added in error.

Fixes: dfe21dcabac0 ("ARM: defconfig: Enable ax88796c driver for Exynos boards")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/configs/multi_v7_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 7ac539231a90..ecf743b3409d 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -254,7 +254,6 @@ CONFIG_SATA_HIGHBANK=y
 CONFIG_SATA_MV=y
 CONFIG_SATA_RCAR=y
 CONFIG_NETDEVICES=y
-CONFIG_NET_VENDOR_ASIX=y
 CONFIG_VIRTIO_NET=y
 CONFIG_B53_SPI_DRIVER=m
 CONFIG_B53_MDIO_DRIVER=m
-- 
2.29.2
[PATCH 04/11] ARM: defconfig: drop CONFIG_SERIAL_OMAP references
Posted by Arnd Bergmann 3 years, 7 months ago
From: Arnd Bergmann <arnd@arndb.de>

This driver is mutually exclusive with the new 8250_OMAP
driver, so 'make defconfig' turns it off already. Drop
the reference now.

Fixes: 077e1cde78c3 ("ARM: omap2plus_defconfig: Enable 8250_OMAP")
Fixes: f98d45145e6a ("ARM: multi_v7_defconfig: Enable 8250-omap serial driver and use it by default")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/configs/multi_v7_defconfig  | 2 --
 arch/arm/configs/omap2plus_defconfig | 2 --
 2 files changed, 4 deletions(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index ecf743b3409d..4cfe795981c8 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -377,8 +377,6 @@ CONFIG_SERIAL_MSM=y
 CONFIG_SERIAL_MSM_CONSOLE=y
 CONFIG_SERIAL_VT8500=y
 CONFIG_SERIAL_VT8500_CONSOLE=y
-CONFIG_SERIAL_OMAP=y
-CONFIG_SERIAL_OMAP_CONSOLE=y
 CONFIG_SERIAL_BCM63XX=y
 CONFIG_SERIAL_BCM63XX_CONSOLE=y
 CONFIG_SERIAL_XILINX_PS_UART=y
diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index e273365838cb..89cda0877c52 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -419,8 +419,6 @@ CONFIG_SERIAL_8250_DETECT_IRQ=y
 CONFIG_SERIAL_8250_RSA=y
 CONFIG_SERIAL_8250_OMAP=y
 CONFIG_SERIAL_OF_PLATFORM=y
-CONFIG_SERIAL_OMAP=y
-CONFIG_SERIAL_OMAP_CONSOLE=y
 CONFIG_SERIAL_DEV_BUS=y
 CONFIG_I2C_CHARDEV=y
 CONFIG_SPI=y
-- 
2.29.2
Re: [PATCH 04/11] ARM: defconfig: drop CONFIG_SERIAL_OMAP references
Posted by Tony Lindgren 3 years, 7 months ago
* Arnd Bergmann <arnd@kernel.org> [220818 13:51]:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This driver is mutually exclusive with the new 8250_OMAP
> driver, so 'make defconfig' turns it off already. Drop
> the reference now.

Acked-by: Tony Lindgren <tony@atomide.com>
[PATCH 05/11] ARM: defconfig: drop CONFIG_DRM_RCAR_LVDS
Posted by Arnd Bergmann 3 years, 7 months ago
From: Arnd Bergmann <arnd@arndb.de>

This is now a hidden symbol, so just drop the defconfig line.

Fixes: 42d95d1b3a9c ("drm/rcar: stop using 'imply' for dependencies")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/configs/multi_v7_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 4cfe795981c8..b3669cf855b3 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -713,7 +713,6 @@ CONFIG_ROCKCHIP_DW_MIPI_DSI=y
 CONFIG_ROCKCHIP_INNO_HDMI=y
 CONFIG_DRM_ATMEL_HLCDC=m
 CONFIG_DRM_RCAR_DU=m
-CONFIG_DRM_RCAR_LVDS=y
 CONFIG_DRM_SUN4I=m
 CONFIG_DRM_MSM=m
 CONFIG_DRM_FSL_DCU=m
-- 
2.29.2
[PATCH 06/11] ARM: defconfig: drop CONFIG_PTP_1588_CLOCK=y
Posted by Arnd Bergmann 3 years, 7 months ago
From: Arnd Bergmann <arnd@arndb.de>

PTP support is now enabled by default for configurations with
ethernet support, so drop the redundant entries in defconfig
files.

Fixes: e5f31552674e ("ethernet: fix PTP_1588_CLOCK dependencies")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/configs/keystone_defconfig  | 1 -
 arch/arm/configs/multi_v7_defconfig  | 1 -
 arch/arm/configs/omap2plus_defconfig | 1 -
 3 files changed, 3 deletions(-)

diff --git a/arch/arm/configs/keystone_defconfig b/arch/arm/configs/keystone_defconfig
index 97f958d55019..4a5b9adbf2a1 100644
--- a/arch/arm/configs/keystone_defconfig
+++ b/arch/arm/configs/keystone_defconfig
@@ -152,7 +152,6 @@ CONFIG_SPI=y
 CONFIG_SPI_CADENCE_QUADSPI=y
 CONFIG_SPI_DAVINCI=y
 CONFIG_SPI_SPIDEV=y
-CONFIG_PTP_1588_CLOCK=y
 CONFIG_PINCTRL_SINGLE=y
 CONFIG_GPIOLIB=y
 CONFIG_GPIO_SYSFS=y
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index b3669cf855b3..a523591798cb 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -462,7 +462,6 @@ CONFIG_SPI_TEGRA20_SLINK=y
 CONFIG_SPI_XILINX=y
 CONFIG_SPI_SPIDEV=y
 CONFIG_SPMI=y
-CONFIG_PTP_1588_CLOCK=y
 CONFIG_PINCTRL_AS3722=y
 CONFIG_PINCTRL_MICROCHIP_SGPIO=y
 CONFIG_PINCTRL_OCELOT=y
diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index 89cda0877c52..39c89576ab2b 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -428,7 +428,6 @@ CONFIG_SPI_TI_QSPI=m
 CONFIG_HSI=m
 CONFIG_OMAP_SSI=m
 CONFIG_SSI_PROTOCOL=m
-CONFIG_PTP_1588_CLOCK=y
 CONFIG_PINCTRL_SINGLE=y
 CONFIG_DEBUG_GPIO=y
 CONFIG_GPIO_SYSFS=y
-- 
2.29.2
Re: [PATCH 06/11] ARM: defconfig: drop CONFIG_PTP_1588_CLOCK=y
Posted by Richard Cochran 3 years, 7 months ago
On Thu, Aug 18, 2022 at 03:57:15PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> PTP support is now enabled by default for configurations with
> ethernet support, so drop the redundant entries in defconfig
> files.
> 
> Fixes: e5f31552674e ("ethernet: fix PTP_1588_CLOCK dependencies")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Richard Cochran <richardcochran@gmail.com>
[PATCH 07/11] ARM: defconfig: drop CONFIG_SND_SOC_FSL_SAI
Posted by Arnd Bergmann 3 years, 7 months ago
From: Arnd Bergmann <arnd@arndb.de>

This is selected by CONFIG_SND_SOC_FSL_ASOC_CARD=m, so the
extra line is redundant.

Fixes: 212e3b6b8734 ("ARM: configs: Enable more audio support for i.MX")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/configs/multi_v7_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index a523591798cb..7af627a816ec 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -778,7 +778,6 @@ CONFIG_SND_ATMEL_SOC_I2S=m
 CONFIG_SND_BCM2835_SOC_I2S=m
 CONFIG_SND_IMX_SOC=m
 CONFIG_SND_SOC_FSL_ASOC_CARD=m
-CONFIG_SND_SOC_FSL_SAI=m
 CONFIG_SND_PXA_SOC_SSP=m
 CONFIG_SND_MMP_SOC_SSPA=m
 CONFIG_SND_PXA910_SOC=m
-- 
2.29.2
[PATCH 08/11] ARM: defconfig: drop CONFIG_USB_FSL_USB2
Posted by Arnd Bergmann 3 years, 7 months ago
From: Arnd Bergmann <arnd@arndb.de>

USB_FSL_USB2 is no longer available for Arm platforms and
was replaced by the chipidea driver.

Fixes: a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/configs/multi_v7_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 7af627a816ec..1cb293adecb1 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -869,7 +869,6 @@ CONFIG_USB_GPIO_VBUS=y
 CONFIG_USB_ISP1301=y
 CONFIG_USB_MXS_PHY=y
 CONFIG_USB_GADGET=y
-CONFIG_USB_FSL_USB2=y
 CONFIG_USB_RENESAS_USBHS_UDC=m
 CONFIG_USB_ASPEED_VHUB=m
 CONFIG_USB_CONFIGFS=m
-- 
2.29.2
Re: [PATCH 08/11] ARM: defconfig: drop CONFIG_USB_FSL_USB2
Posted by Greg Kroah-Hartman 3 years, 7 months ago
On Thu, Aug 18, 2022 at 03:57:17PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> USB_FSL_USB2 is no longer available for Arm platforms and
> was replaced by the chipidea driver.
> 
> Fixes: a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/arm/configs/multi_v7_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 7af627a816ec..1cb293adecb1 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -869,7 +869,6 @@ CONFIG_USB_GPIO_VBUS=y
>  CONFIG_USB_ISP1301=y
>  CONFIG_USB_MXS_PHY=y
>  CONFIG_USB_GADGET=y
> -CONFIG_USB_FSL_USB2=y
>  CONFIG_USB_RENESAS_USBHS_UDC=m
>  CONFIG_USB_ASPEED_VHUB=m
>  CONFIG_USB_CONFIGFS=m
> -- 
> 2.29.2
> 

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[PATCH 09/11] ARM: defconfig: drop CONFIG_MICROCHIP_PIT64B
Posted by Arnd Bergmann 3 years, 7 months ago
From: Arnd Bergmann <arnd@arndb.de>

This is now default-enabled when CONFIG_SOC_SAMA7 is
used, so the defconfig entry can be dropped.

Fixes: f611af4c3bfa ("ARM: at91: Kconfig: implement PIT64B selection")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/configs/multi_v7_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 1cb293adecb1..2b564defe33e 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -1044,7 +1044,6 @@ CONFIG_MSM_MMCC_8960=y
 CONFIG_MSM_MMCC_8974=y
 CONFIG_HWSPINLOCK=y
 CONFIG_HWSPINLOCK_QCOM=y
-CONFIG_MICROCHIP_PIT64B=y
 CONFIG_BCM2835_MBOX=y
 CONFIG_QCOM_APCS_IPC=y
 CONFIG_QCOM_IPCC=y
-- 
2.29.2
Re: [PATCH 09/11] ARM: defconfig: drop CONFIG_MICROCHIP_PIT64B
Posted by Claudiu.Beznea@microchip.com 3 years, 7 months ago
On 18.08.2022 16:57, Arnd Bergmann wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This is now default-enabled when CONFIG_SOC_SAMA7 is
> used, so the defconfig entry can be dropped.
> 
> Fixes: f611af4c3bfa ("ARM: at91: Kconfig: implement PIT64B selection")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Claudiu Beznea <claudiu.beznea@microchip.com>


> ---
>  arch/arm/configs/multi_v7_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 1cb293adecb1..2b564defe33e 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -1044,7 +1044,6 @@ CONFIG_MSM_MMCC_8960=y
>  CONFIG_MSM_MMCC_8974=y
>  CONFIG_HWSPINLOCK=y
>  CONFIG_HWSPINLOCK_QCOM=y
> -CONFIG_MICROCHIP_PIT64B=y
>  CONFIG_BCM2835_MBOX=y
>  CONFIG_QCOM_APCS_IPC=y
>  CONFIG_QCOM_IPCC=y
> --
> 2.29.2
> 

[PATCH 10/11] ARM: defconfig: fix CONFIG_SND_SOC_AC97_CODEC name
Posted by Arnd Bergmann 3 years, 7 months ago
From: Arnd Bergmann <arnd@arndb.de>

The CONFIG_SND_SOC_AC97 symbol was recently enabled but does not
actually exist. From the patch description, I assume that this
was meant to be CONFIG_SND_SOC_AC97_CODEC, which is used in
imx_v6_v7_defconfig.

Fixes: 2cc1cd26e913 ("ARM: configs: Enable ASoC AC'97 glue")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/configs/multi_v7_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 2b564defe33e..af79b21e2000 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -814,7 +814,7 @@ CONFIG_SND_SOC_TEGRA_TRIMSLICE=m
 CONFIG_SND_SOC_TEGRA_ALC5632=m
 CONFIG_SND_SOC_TEGRA_MAX98090=m
 CONFIG_SND_SOC_DAVINCI_MCASP=m
-CONFIG_SND_SOC_AC97=m
+CONFIG_SND_SOC_AC97_CODEC=m
 CONFIG_SND_SOC_AK4642=m
 CONFIG_SND_SOC_CPCAP=m
 CONFIG_SND_SOC_CS42L51_I2C=m
-- 
2.29.2
[PATCH 11/11] musb: fix USB_MUSB_TUSB6010 dependency
Posted by Arnd Bergmann 3 years, 7 months ago
From: Arnd Bergmann <arnd@arndb.de>

Turning on NOP_USB_XCEIV as builtin broke the TUSB6010 driver because
of an older issue with the depencency.

It is not necessary to forbid NOP_USB_XCEIV=y in combination with
USB_MUSB_HDRC=m, but only the reverse, which causes the link failure
from the original Kconfig change.

Use the correct dependency to still allow NOP_USB_XCEIV=n or
NOP_USB_XCEIV=y but forbid NOP_USB_XCEIV=m when USB_MUSB_HDRC=m
to fix the multi_v7_defconfig for tusb.

Fixes: ab37a7a890c1 ("ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in")
Fixes: c0442479652b ("usb: musb: Fix randconfig build issues for Kconfig options")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/usb/musb/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index f906dfd360d3..6c8f7763e75e 100644
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -86,7 +86,7 @@ config USB_MUSB_TUSB6010
 	tristate "TUSB6010"
 	depends on HAS_IOMEM
 	depends on ARCH_OMAP2PLUS || COMPILE_TEST
-	depends on NOP_USB_XCEIV = USB_MUSB_HDRC # both built-in or both modules
+	depends on NOP_USB_XCEIV!=m || USB_MUSB_HDRC=m
 
 config USB_MUSB_OMAP2PLUS
 	tristate "OMAP2430 and onwards"
-- 
2.29.2
Re: [PATCH 11/11] musb: fix USB_MUSB_TUSB6010 dependency
Posted by Greg Kroah-Hartman 3 years, 7 months ago
On Thu, Aug 18, 2022 at 03:57:20PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Turning on NOP_USB_XCEIV as builtin broke the TUSB6010 driver because
> of an older issue with the depencency.
> 
> It is not necessary to forbid NOP_USB_XCEIV=y in combination with
> USB_MUSB_HDRC=m, but only the reverse, which causes the link failure
> from the original Kconfig change.
> 
> Use the correct dependency to still allow NOP_USB_XCEIV=n or
> NOP_USB_XCEIV=y but forbid NOP_USB_XCEIV=m when USB_MUSB_HDRC=m
> to fix the multi_v7_defconfig for tusb.
> 
> Fixes: ab37a7a890c1 ("ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in")
> Fixes: c0442479652b ("usb: musb: Fix randconfig build issues for Kconfig options")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/usb/musb/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Want me to take this through my tree now?  If so, I can, otherwise
here's a:

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

for your tree.

thanks,

greg k-h
Re: [PATCH 11/11] musb: fix USB_MUSB_TUSB6010 dependency
Posted by Arnd Bergmann 3 years, 7 months ago
On Thu, Aug 18, 2022 at 4:08 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Thu, Aug 18, 2022 at 03:57:20PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Turning on NOP_USB_XCEIV as builtin broke the TUSB6010 driver because
> > of an older issue with the depencency.
> >
> > It is not necessary to forbid NOP_USB_XCEIV=y in combination with
> > USB_MUSB_HDRC=m, but only the reverse, which causes the link failure
> > from the original Kconfig change.
> >
> > Use the correct dependency to still allow NOP_USB_XCEIV=n or
> > NOP_USB_XCEIV=y but forbid NOP_USB_XCEIV=m when USB_MUSB_HDRC=m
> > to fix the multi_v7_defconfig for tusb.
> >
> > Fixes: ab37a7a890c1 ("ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in")
> > Fixes: c0442479652b ("usb: musb: Fix randconfig build issues for Kconfig options")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  drivers/usb/musb/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Want me to take this through my tree now?

Yes, please do.

Thanks,

       Arnd
Re: [PATCH 11/11] musb: fix USB_MUSB_TUSB6010 dependency
Posted by Greg Kroah-Hartman 3 years, 7 months ago
On Thu, Aug 18, 2022 at 04:27:17PM +0200, Arnd Bergmann wrote:
> On Thu, Aug 18, 2022 at 4:08 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Aug 18, 2022 at 03:57:20PM +0200, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > Turning on NOP_USB_XCEIV as builtin broke the TUSB6010 driver because
> > > of an older issue with the depencency.
> > >
> > > It is not necessary to forbid NOP_USB_XCEIV=y in combination with
> > > USB_MUSB_HDRC=m, but only the reverse, which causes the link failure
> > > from the original Kconfig change.
> > >
> > > Use the correct dependency to still allow NOP_USB_XCEIV=n or
> > > NOP_USB_XCEIV=y but forbid NOP_USB_XCEIV=m when USB_MUSB_HDRC=m
> > > to fix the multi_v7_defconfig for tusb.
> > >
> > > Fixes: ab37a7a890c1 ("ARM: multi_v7_defconfig: Make NOP_USB_XCEIV driver built-in")
> > > Fixes: c0442479652b ("usb: musb: Fix randconfig build issues for Kconfig options")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > >  drivers/usb/musb/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Want me to take this through my tree now?
> 
> Yes, please do.

Now done, thanks!