1. Patchew
  2. linux
  3. View series

[PATCH] media: meson: vdec: Add MODULE_FIRMWARE macro

Juerg Haefliger posted 1 patch 3 years, 7 months ago
There is a newer version of this series
.../staging/media/meson/vdec/vdec_platform.c  | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
[PATCH] media: meson: vdec: Add MODULE_FIRMWARE macro
Posted by Juerg Haefliger 3 years, 7 months ago 
The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
provide that information via modinfo.

Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
---
 .../staging/media/meson/vdec/vdec_platform.c  | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
index 88c9d72e1c83..c7750d4be848 100644
--- a/drivers/staging/media/meson/vdec/vdec_platform.c
+++ b/drivers/staging/media/meson/vdec/vdec_platform.c
@@ -280,3 +280,23 @@ const struct vdec_platform vdec_platform_sm1 = {
 	.num_formats = ARRAY_SIZE(vdec_formats_sm1),
 	.revision = VDEC_REVISION_SM1,
 };
+
+MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
+MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
+MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
+MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");
-- 
2.34.1
Re: [PATCH] media: meson: vdec: Add MODULE_FIRMWARE macro
Posted by Neil Armstrong 3 years, 7 months ago 
On 17/08/2022 16:05, Juerg Haefliger wrote:
> The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
> provide that information via modinfo.
> 
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> ---
>   .../staging/media/meson/vdec/vdec_platform.c  | 20 +++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
> index 88c9d72e1c83..c7750d4be848 100644
> --- a/drivers/staging/media/meson/vdec/vdec_platform.c
> +++ b/drivers/staging/media/meson/vdec/vdec_platform.c
> @@ -280,3 +280,23 @@ const struct vdec_platform vdec_platform_sm1 = {
>   	.num_formats = ARRAY_SIZE(vdec_formats_sm1),
>   	.revision = VDEC_REVISION_SM1,
>   };
> +
> +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");

Duplicate

> +MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
> +MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");

DDDDDDDuplicate

> +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");

Duplicate

> +MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");

With the duplicate entries removed, please add my:
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Re: [PATCH] media: meson: vdec: Add MODULE_FIRMWARE macro
Posted by Juerg Haefliger 3 years, 7 months ago 
On Wed, 17 Aug 2022 18:08:19 +0200
Neil Armstrong <narmstrong@baylibre.com> wrote:

> On 17/08/2022 16:05, Juerg Haefliger wrote:
> > The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
> > provide that information via modinfo.
> > 
> > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> > ---
> >   .../staging/media/meson/vdec/vdec_platform.c  | 20 +++++++++++++++++++
> >   1 file changed, 20 insertions(+)
> > 
> > diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
> > index 88c9d72e1c83..c7750d4be848 100644
> > --- a/drivers/staging/media/meson/vdec/vdec_platform.c
> > +++ b/drivers/staging/media/meson/vdec/vdec_platform.c
> > @@ -280,3 +280,23 @@ const struct vdec_platform vdec_platform_sm1 = {
> >   	.num_formats = ARRAY_SIZE(vdec_formats_sm1),
> >   	.revision = VDEC_REVISION_SM1,
> >   };
> > +
> > +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");  
> 
> Duplicate

Oh this is embarrassing :-(


> > +MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");  
> 
> DDDDDDDuplicate
> 
> > +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
> > +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");  
> 
> Duplicate
> 
> > +MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
> > +MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");  
> 
> With the duplicate entries removed, please add my:
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Will do. Thanks for the review.

...Juerg
[PATCH v2] media: meson: vdec: Add MODULE_FIRMWARE macro
Posted by Juerg Haefliger 3 years, 7 months ago 
The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
provide that information via modinfo.

Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

---
v2:
  - Drop duplicates
  - Add Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/staging/media/meson/vdec/vdec_platform.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
index 88c9d72e1c83..70c9fd7c8bc5 100644
--- a/drivers/staging/media/meson/vdec/vdec_platform.c
+++ b/drivers/staging/media/meson/vdec/vdec_platform.c
@@ -280,3 +280,12 @@ const struct vdec_platform vdec_platform_sm1 = {
 	.num_formats = ARRAY_SIZE(vdec_formats_sm1),
 	.revision = VDEC_REVISION_SM1,
 };
+
+MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
+MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
+MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");
-- 
2.34.1
[PATCH v2 resend] media: meson: vdec: Add MODULE_FIRMWARE macro
Posted by Juerg Haefliger 3 years, 2 months ago 
The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
provide that information via modinfo.

Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

---
v2:
  - Drop duplicates
  - Add Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/staging/media/meson/vdec/vdec_platform.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
index 88c9d72e1c83..70c9fd7c8bc5 100644
--- a/drivers/staging/media/meson/vdec/vdec_platform.c
+++ b/drivers/staging/media/meson/vdec/vdec_platform.c
@@ -280,3 +280,12 @@ const struct vdec_platform vdec_platform_sm1 = {
 	.num_formats = ARRAY_SIZE(vdec_formats_sm1),
 	.revision = VDEC_REVISION_SM1,
 };
+
+MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
+MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
+MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");
-- 
2.34.1
Re: [PATCH v2 resend] media: meson: vdec: Add MODULE_FIRMWARE macro
Posted by Juerg Haefliger 2 years, 10 months ago 
Ping


> The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
> provide that information via modinfo.
> 
> Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> 
> ---
> v2:
>   - Drop duplicates
>   - Add Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  drivers/staging/media/meson/vdec/vdec_platform.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
> index 88c9d72e1c83..70c9fd7c8bc5 100644
> --- a/drivers/staging/media/meson/vdec/vdec_platform.c
> +++ b/drivers/staging/media/meson/vdec/vdec_platform.c
> @@ -280,3 +280,12 @@ const struct vdec_platform vdec_platform_sm1 = {
>  	.num_formats = ARRAY_SIZE(vdec_formats_sm1),
>  	.revision = VDEC_REVISION_SM1,
>  };
> +
> +MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
> +MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
> +MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
> +MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
> +MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");
Re: [PATCH v2 resend] media: meson: vdec: Add MODULE_FIRMWARE macro
Posted by Dan Carpenter 2 years, 10 months ago 
On Tue, Jun 13, 2023 at 11:50:18AM +0200, Juerg Haefliger wrote:
> Ping
> 

You CC'd almost a hundred different mailing lists but you left out the
one that matters.  Resend and CC linux-media@vger.kernel.org

The linux-media maintainers work off patchwork so they'll never see this
patch as is.

regards,
dan carpenter
[PATCH v2 resend 2] media: meson: vdec: Add MODULE_FIRMWARE macro
Posted by Juerg Haefliger 2 years, 10 months ago 
The meson-vdec module loads firmware so add MODULE_FIRMWARE macros to
provide that information via modinfo.

Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

---
v2 resend 2:
  - cc linux-media@vger.kernel.org
v2:
  - Drop duplicates
  - Add Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/staging/media/meson/vdec/vdec_platform.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/staging/media/meson/vdec/vdec_platform.c b/drivers/staging/media/meson/vdec/vdec_platform.c
index 88c9d72e1c83..70c9fd7c8bc5 100644
--- a/drivers/staging/media/meson/vdec/vdec_platform.c
+++ b/drivers/staging/media/meson/vdec/vdec_platform.c
@@ -280,3 +280,12 @@ const struct vdec_platform vdec_platform_sm1 = {
 	.num_formats = ARRAY_SIZE(vdec_formats_sm1),
 	.revision = VDEC_REVISION_SM1,
 };
+
+MODULE_FIRMWARE("meson/vdec/g12a_h264.bin");
+MODULE_FIRMWARE("meson/vdec/g12a_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxbb_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_h264.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_mpeg12.bin");
+MODULE_FIRMWARE("meson/vdec/gxl_vp9.bin");
+MODULE_FIRMWARE("meson/vdec/gxm_h264.bin");
+MODULE_FIRMWARE("meson/vdec/sm1_vp9_mmu.bin");
-- 
2.37.2

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.