ALSA: hda: Minor cleanups

[PATCH 0/4] ALSA: hda: Minor cleanups

Posted by Amadeusz Sławiński 3 years, 7 months ago

First two patches are small refactoring of code to use poll macros
instead of open coding register checks.
Following two patches remove unused defines from code.

Amadeusz Sławiński (4):
  ALSA: hda: Move stream-register polling macros
  ALSA: hda: Rework snd_hdac_stream_reset() to use macros
  ALSA: hda: Remove unused MAX_PIN_CONFIGS constant
  ALSA: hda: Remove unused defines

 include/sound/hdaudio.h     |  6 ++++++
 include/sound/hdaudio_ext.h |  6 ------
 sound/hda/hdac_stream.c     | 27 +++++++--------------------
 sound/pci/hda/hda_intel.c   |  7 -------
 sound/pci/hda/hda_sysfs.c   |  2 --
 5 files changed, 13 insertions(+), 35 deletions(-)

-- 
2.25.1

Re: [PATCH 0/4] ALSA: hda: Minor cleanups

Posted by Cezary Rojewski 3 years, 7 months ago

On 2022-08-17 3:11 PM, Amadeusz Sławiński wrote:
> First two patches are small refactoring of code to use poll macros
> instead of open coding register checks.
> Following two patches remove unused defines from code.
> 
> Amadeusz Sławiński (4):
>    ALSA: hda: Move stream-register polling macros
>    ALSA: hda: Rework snd_hdac_stream_reset() to use macros
>    ALSA: hda: Remove unused MAX_PIN_CONFIGS constant
>    ALSA: hda: Remove unused defines


Reviewed by me before sending, plus from the test results patchset 
causes no regression in the avs-driver CI.

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>

Re: [PATCH 0/4] ALSA: hda: Minor cleanups

Posted by Cezary Rojewski 3 years, 7 months ago

On 2022-08-17 3:23 PM, Cezary Rojewski wrote:
> On 2022-08-17 3:11 PM, Amadeusz Sławiński wrote:
>> First two patches are small refactoring of code to use poll macros
>> instead of open coding register checks.
>> Following two patches remove unused defines from code.
>>
>> Amadeusz Sławiński (4):
>>    ALSA: hda: Move stream-register polling macros
>>    ALSA: hda: Rework snd_hdac_stream_reset() to use macros
>>    ALSA: hda: Remove unused MAX_PIN_CONFIGS constant
>>    ALSA: hda: Remove unused defines
> 
> 
> Reviewed by me before sending, plus from the test results patchset 
> causes no regression in the avs-driver CI.
> 
> Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>


RESEND. Patch was blocked so my tag did not make it to the list.