[PATCH v1 0/6] Mutex wrapper, locking and memory leak fixes

Ian Rogers posted 6 patches 3 years, 7 months ago
There is a newer version of this series
tools/perf/Makefile.config                 |   5 +
tools/perf/bench/epoll-ctl.c               |  33 +++----
tools/perf/bench/epoll-wait.c              |  33 +++----
tools/perf/bench/futex-hash.c              |  33 +++----
tools/perf/bench/futex-lock-pi.c           |  33 +++----
tools/perf/bench/futex-requeue.c           |  33 +++----
tools/perf/bench/futex-wake-parallel.c     |  33 +++----
tools/perf/bench/futex-wake.c              |  33 +++----
tools/perf/bench/numa.c                    |  93 +++++++-----------
tools/perf/builtin-inject.c                |   4 +
tools/perf/builtin-lock.c                  |   1 -
tools/perf/builtin-record.c                |  13 ++-
tools/perf/builtin-sched.c                 |  75 ++++++++-------
tools/perf/builtin-top.c                   |  45 ++++-----
tools/perf/tests/mmap-basic.c              |   2 -
tools/perf/tests/openat-syscall-all-cpus.c |   2 +-
tools/perf/tests/perf-record.c             |   2 -
tools/perf/ui/browser.c                    |  20 ++--
tools/perf/ui/browsers/annotate.c          |  12 +--
tools/perf/ui/setup.c                      |   5 +-
tools/perf/ui/tui/helpline.c               |   5 +-
tools/perf/ui/tui/progress.c               |   8 +-
tools/perf/ui/tui/setup.c                  |   8 +-
tools/perf/ui/tui/util.c                   |  18 ++--
tools/perf/ui/ui.h                         |   4 +-
tools/perf/util/Build                      |   1 +
tools/perf/util/annotate.c                 |  15 +--
tools/perf/util/annotate.h                 |   4 +-
tools/perf/util/bpf-event.h                |   1 -
tools/perf/util/build-id.c                 |  12 ++-
tools/perf/util/dso.c                      |  19 ++--
tools/perf/util/dso.h                      |   4 +-
tools/perf/util/hist.c                     |   6 +-
tools/perf/util/hist.h                     |   4 +-
tools/perf/util/map.c                      |   3 +
tools/perf/util/mmap.h                     |   1 -
tools/perf/util/mutex.c                    |  99 +++++++++++++++++++
tools/perf/util/mutex.h                    | 105 +++++++++++++++++++++
tools/perf/util/probe-event.c              |   3 +
tools/perf/util/symbol.c                   |   4 +-
tools/perf/util/top.h                      |   5 +-
41 files changed, 529 insertions(+), 310 deletions(-)
create mode 100644 tools/perf/util/mutex.c
create mode 100644 tools/perf/util/mutex.h
[PATCH v1 0/6] Mutex wrapper, locking and memory leak fixes
Posted by Ian Rogers 3 years, 7 months ago
When fixing a locking race and memory leak in:
https://lore.kernel.org/linux-perf-users/20211118193714.2293728-1-irogers@google.com/

It was requested that debug mutex code be separated out into its own
files. This was done by Pavithra Gurushankar in:
https://lore.kernel.org/lkml/20220727111954.105118-1-gpavithrasha@gmail.com/

These patches fix issues with the previous patches, add in the
original dso->nsinfo fix and then build on our mutex wrapper with
clang's -Wthread-safety analysis. The analysis found missing unlocks
in builtin-sched.c which are fixed and -Wthread-safety is enabled by
default when building with clang.

Ian Rogers (4):
  perf dso: Hold lock when accessing nsinfo
  perf mutex: Add thread safety annotations
  perf mutex: Fix thread safety analysis
  perf build: Enable -Wthread-safety with clang

Pavithra Gurushankar (2):
  perf mutex: Wrapped usage of mutex and cond
  perf mutex: Update use of pthread mutex/cond

 tools/perf/Makefile.config                 |   5 +
 tools/perf/bench/epoll-ctl.c               |  33 +++----
 tools/perf/bench/epoll-wait.c              |  33 +++----
 tools/perf/bench/futex-hash.c              |  33 +++----
 tools/perf/bench/futex-lock-pi.c           |  33 +++----
 tools/perf/bench/futex-requeue.c           |  33 +++----
 tools/perf/bench/futex-wake-parallel.c     |  33 +++----
 tools/perf/bench/futex-wake.c              |  33 +++----
 tools/perf/bench/numa.c                    |  93 +++++++-----------
 tools/perf/builtin-inject.c                |   4 +
 tools/perf/builtin-lock.c                  |   1 -
 tools/perf/builtin-record.c                |  13 ++-
 tools/perf/builtin-sched.c                 |  75 ++++++++-------
 tools/perf/builtin-top.c                   |  45 ++++-----
 tools/perf/tests/mmap-basic.c              |   2 -
 tools/perf/tests/openat-syscall-all-cpus.c |   2 +-
 tools/perf/tests/perf-record.c             |   2 -
 tools/perf/ui/browser.c                    |  20 ++--
 tools/perf/ui/browsers/annotate.c          |  12 +--
 tools/perf/ui/setup.c                      |   5 +-
 tools/perf/ui/tui/helpline.c               |   5 +-
 tools/perf/ui/tui/progress.c               |   8 +-
 tools/perf/ui/tui/setup.c                  |   8 +-
 tools/perf/ui/tui/util.c                   |  18 ++--
 tools/perf/ui/ui.h                         |   4 +-
 tools/perf/util/Build                      |   1 +
 tools/perf/util/annotate.c                 |  15 +--
 tools/perf/util/annotate.h                 |   4 +-
 tools/perf/util/bpf-event.h                |   1 -
 tools/perf/util/build-id.c                 |  12 ++-
 tools/perf/util/dso.c                      |  19 ++--
 tools/perf/util/dso.h                      |   4 +-
 tools/perf/util/hist.c                     |   6 +-
 tools/perf/util/hist.h                     |   4 +-
 tools/perf/util/map.c                      |   3 +
 tools/perf/util/mmap.h                     |   1 -
 tools/perf/util/mutex.c                    |  99 +++++++++++++++++++
 tools/perf/util/mutex.h                    | 105 +++++++++++++++++++++
 tools/perf/util/probe-event.c              |   3 +
 tools/perf/util/symbol.c                   |   4 +-
 tools/perf/util/top.h                      |   5 +-
 41 files changed, 529 insertions(+), 310 deletions(-)
 create mode 100644 tools/perf/util/mutex.c
 create mode 100644 tools/perf/util/mutex.h

-- 
2.37.1.595.g718a3a8f04-goog