[PATCH] core: Variable type completion

Xin Gao posted 1 patch 3 years, 7 months ago
net/core/netclassid_cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] core: Variable type completion
Posted by Xin Gao 3 years, 7 months ago
'unsigned int' is better than 'unsigned'.

Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
---
 net/core/netclassid_cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/netclassid_cgroup.c b/net/core/netclassid_cgroup.c
index 1a6a86693b74..d6a70aeaa503 100644
--- a/net/core/netclassid_cgroup.c
+++ b/net/core/netclassid_cgroup.c
@@ -66,7 +66,7 @@ struct update_classid_context {
 
 #define UPDATE_CLASSID_BATCH 1000
 
-static int update_classid_sock(const void *v, struct file *file, unsigned n)
+static int update_classid_sock(const void *v, struct file *file, unsigned int n)
 {
 	struct update_classid_context *ctx = (void *)v;
 	struct socket *sock = sock_from_file(file);
-- 
2.30.2
Re: [PATCH] core: Variable type completion
Posted by Jakub Kicinski 3 years, 7 months ago
On Wed, 17 Aug 2022 09:35:29 +0800 Xin Gao wrote:
> 'unsigned int' is better than 'unsigned'.

Please resend with the following subject:

[PATCH net-next] net: cgroup: complete unsigned type name
Re: [PATCH] core: Variable type completion
Posted by Tejun Heo 3 years, 7 months ago
On Fri, Aug 19, 2022 at 04:47:31PM -0700, Jakub Kicinski wrote:
> On Wed, 17 Aug 2022 09:35:29 +0800 Xin Gao wrote:
> > 'unsigned int' is better than 'unsigned'.
> 
> Please resend with the following subject:
> 
> [PATCH net-next] net: cgroup: complete unsigned type name

Out of curiosity, why is 'unsigned int' better than 'unsigned'?

Thanks.

-- 
tejun
Re: [PATCH] core: Variable type completion
Posted by Jakub Kicinski 3 years, 7 months ago
On Fri, 19 Aug 2022 14:07:26 -1000 Tejun Heo wrote:
> On Fri, Aug 19, 2022 at 04:47:31PM -0700, Jakub Kicinski wrote:
> > On Wed, 17 Aug 2022 09:35:29 +0800 Xin Gao wrote:  
> > > 'unsigned int' is better than 'unsigned'.  
> > 
> > Please resend with the following subject:
> > 
> > [PATCH net-next] net: cgroup: complete unsigned type name  
> 
> Out of curiosity, why is 'unsigned int' better than 'unsigned'?

Good question, a citation in the commit message would also be good.