[PATCH v1 0/7] i2c-mlxbf.c: bug fixes and new feature support

Asmaa Mnebhi posted 7 patches 3 years, 7 months ago
There is a newer version of this series
.../bindings/i2c/mellanox,i2c-mlxbf.yaml      |  30 +-
MAINTAINERS                                   |   1 +
drivers/i2c/busses/i2c-mlxbf.c                | 821 ++++++++++--------
3 files changed, 467 insertions(+), 385 deletions(-)
[PATCH v1 0/7] i2c-mlxbf.c: bug fixes and new feature support
Posted by Asmaa Mnebhi 3 years, 7 months ago
This is a series of patches fixing several bugs and implementing
new features.

Bug fixes:
1) Fix the frequency calculation
2) Fix incorrect base address passed during io write
3) prevent stack overflow in mlxbf_i2c_smbus_start_transaction()
4) Support lock mechanism

New features:
1) remove unnecessary IRQF_ONESHOT flag
2) Support multi slave functionality
3) Support BlueField-3 SoC

Asmaa Mnebhi (7):
  i2c-mlxbf.c: Fix frequency calculation
  i2c-mlxbf.c: remove IRQF_ONESHOT
  i2c-mlxbf: add multi slave functionality
  i2c-mlxbf.c: incorrect base address passed during io write
  i2c-mlxbf: prevent stack overflow in
    mlxbf_i2c_smbus_start_transaction()
  i2c-mlxbf.c: support BlueField-3 SoC
  i2c-mlxbf.c: support lock mechanism

 .../bindings/i2c/mellanox,i2c-mlxbf.yaml      |  30 +-
 MAINTAINERS                                   |   1 +
 drivers/i2c/busses/i2c-mlxbf.c                | 821 ++++++++++--------
 3 files changed, 467 insertions(+), 385 deletions(-)

-- 
2.30.1
Re: [PATCH v1 0/7] i2c-mlxbf.c: bug fixes and new feature support
Posted by Wolfram Sang 3 years, 7 months ago
Hi,

> Bug fixes:
> 1) Fix the frequency calculation
> 2) Fix incorrect base address passed during io write
> 3) prevent stack overflow in mlxbf_i2c_smbus_start_transaction()
> 4) Support lock mechanism

If possible, the bugfixes should all come first so they can easily be
backported. Also, they should have a Fixes: tag where possible.

If the above is possible, can you reorder, add Fixes tags and resend?

Happy hacking,

   Wolfram
RE: [PATCH v1 0/7] i2c-mlxbf.c: bug fixes and new feature support
Posted by Asmaa Mnebhi 3 years, 7 months ago
Sure!

-----Original Message-----
From: Wolfram Sang <wsa@kernel.org> 
Sent: Thursday, August 18, 2022 12:24 PM
To: Asmaa Mnebhi <asmaa@nvidia.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>; linux-i2c@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/7] i2c-mlxbf.c: bug fixes and new feature support

Hi,

> Bug fixes:
> 1) Fix the frequency calculation
> 2) Fix incorrect base address passed during io write
> 3) prevent stack overflow in mlxbf_i2c_smbus_start_transaction()
> 4) Support lock mechanism

If possible, the bugfixes should all come first so they can easily be backported. Also, they should have a Fixes: tag where possible.

If the above is possible, can you reorder, add Fixes tags and resend?

Happy hacking,

   Wolfram