[PATCH] KEYS: Variable type completion

Xin Gao posted 1 patch 3 years, 7 months ago
security/keys/keyctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] KEYS: Variable type completion
Posted by Xin Gao 3 years, 7 months ago
'unsigned int' is better than 'unsigned'.

Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
---
 security/keys/keyctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c
index 96a92a645216..4564505e7594 100644
--- a/security/keys/keyctl.c
+++ b/security/keys/keyctl.c
@@ -44,7 +44,7 @@ static const unsigned char keyrings_capabilities[2] = {
 
 static int key_get_type_from_user(char *type,
 				  const char __user *_type,
-				  unsigned len)
+				  unsigned int len)
 {
 	int ret;
 
-- 
2.30.2
Re: [PATCH] KEYS: Variable type completion
Posted by Al Viro 3 years, 7 months ago
On Wed, Aug 17, 2022 at 02:01:10AM +0800, Xin Gao wrote:
> 'unsigned int' is better than 'unsigned'.

Explain.

You keep sending rather pointless patches with declarative
commit messages instead of explanations.  Why is 'unsigned
int' better than 'unsigned'?  Demonstrate understanding -
simple reference to checkpatch.pl does *NOT* count.