[PATCH] arm64: dts: microchip: use "okay" instead of "ok"

Robert Marko posted 1 patch 3 years, 7 months ago
arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi | 2 +-
arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
[PATCH] arm64: dts: microchip: use "okay" instead of "ok"
Posted by Robert Marko 3 years, 7 months ago
DT specification only allows "okay", and for projects like U-boot
status = "ok" won't enable the device at all.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi | 2 +-
 arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi
index 4d55ae868b50..80217d5f3f66 100644
--- a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi
+++ b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi
@@ -529,7 +529,7 @@ i2c_sfp20: i2c_sfp20 {
 };
 
 &mdio3 {
-	status = "ok";
+	status = "okay";
 	phy64: ethernet-phy@64 {
 		reg = <28>;
 	};
diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi
index ec90bda7ed6a..0760cf2e48bc 100644
--- a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi
+++ b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi
@@ -208,7 +208,7 @@ sfp_eth63: sfp-eth63 {
 };
 
 &mdio0 {
-	status = "ok";
+	status = "okay";
 	phy0: ethernet-phy@0 {
 		reg = <0>;
 	};
@@ -284,7 +284,7 @@ phy23: ethernet-phy@23 {
 };
 
 &mdio1 {
-	status = "ok";
+	status = "okay";
 	phy24: ethernet-phy@24 {
 		reg = <0>;
 	};
@@ -360,7 +360,7 @@ phy47: ethernet-phy@47 {
 };
 
 &mdio3 {
-	status = "ok";
+	status = "okay";
 	phy64: ethernet-phy@64 {
 		reg = <28>;
 	};
-- 
2.37.2
Re: [PATCH] arm64: dts: microchip: use "okay" instead of "ok"
Posted by Krzysztof Kozlowski 3 years, 7 months ago
On 16/08/2022 13:36, Robert Marko wrote:
> DT specification only allows "okay", and for projects like U-boot
> status = "ok" won't enable the device at all.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof