[PATCH] arm64: dts: imx8mm-venice-gw7901: fix port/phy validation

Tim Harvey posted 1 patch 3 years, 8 months ago
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 4 ++++
1 file changed, 4 insertions(+)
[PATCH] arm64: dts: imx8mm-venice-gw7901: fix port/phy validation
Posted by Tim Harvey 3 years, 8 months ago
Since commit 65ac79e18120 ("net: dsa: microchip: add the phylink
get_caps") the phy-mode must be set otherwise the switch driver will
assume "NA" mode and invalidate the port.

Fixes: 65ac79e18120 ("net: dsa: microchip: add the phylink get_caps")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
 arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
index 24737e89038a..96cac0f969a7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
@@ -626,24 +626,28 @@ ports {
 			lan1: port@0 {
 				reg = <0>;
 				label = "lan1";
+				phy-mode = "internal";
 				local-mac-address = [00 00 00 00 00 00];
 			};
 
 			lan2: port@1 {
 				reg = <1>;
 				label = "lan2";
+				phy-mode = "internal";
 				local-mac-address = [00 00 00 00 00 00];
 			};
 
 			lan3: port@2 {
 				reg = <2>;
 				label = "lan3";
+				phy-mode = "internal";
 				local-mac-address = [00 00 00 00 00 00];
 			};
 
 			lan4: port@3 {
 				reg = <3>;
 				label = "lan4";
+				phy-mode = "internal";
 				local-mac-address = [00 00 00 00 00 00];
 			};
 
-- 
2.25.1
Re: [PATCH] arm64: dts: imx8mm-venice-gw7901: fix port/phy validation
Posted by Shawn Guo 3 years, 7 months ago
On Fri, Aug 12, 2022 at 10:20:54AM -0700, Tim Harvey wrote:
> Since commit 65ac79e18120 ("net: dsa: microchip: add the phylink
> get_caps") the phy-mode must be set otherwise the switch driver will
> assume "NA" mode and invalidate the port.
> 
> Fixes: 65ac79e18120 ("net: dsa: microchip: add the phylink get_caps")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>

Applied, thanks!