Documents some previously added attributes:
- dgpu_disable
- egpu_enable
- panel_od

Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
 .../ABI/testing/sysfs-platform-asus-wmi       | 30 ++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi b/Documentation/ABI/testing/sysfs-platform-asus-wmi
index 3e3f2dcf9bfa..541dbfbbbb26 100644
--- a/Documentation/ABI/testing/sysfs-platform-asus-wmi
+++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi
@@ -48,6 +48,34 @@ Description:
 			* 1 - overboost,
 			* 2 - silent
 
+What:		/sys/devices/platform/<platform>/dgpu_disable
+Date:		Aug 2022
+KernelVersion:	5.17
+Contact:	"Luke Jones" <luke@ljones.dev>
+Description:
+		Disable discrete GPU:
+			* 0 - Enable dGPU,
+			* 1 - Disable dGPU,
+
+What:		/sys/devices/platform/<platform>/egpu_enable
+Date:		Aug 2022
+KernelVersion:	5.17
+Contact:	"Luke Jones" <luke@ljones.dev>
+Description:
+		Enable the external GPU paired with ROG X-Flow laptops.
+		Toggling this setting will also trigger ACPI to disable the dGPU:
+			* 0 - Disable,
+			* 1 - Enable,
+
+What:		/sys/devices/platform/<platform>/panel_od
+Date:		Aug 2022
+KernelVersion:	5.17
+Contact:	"Luke Jones" <luke@ljones.dev>
+Description:
+		Enable an LCD response-time boost to reduce or remove ghosting:
+			* 0 - Disable,
+			* 1 - Enable,
+
 What:		/sys/devices/platform/<platform>/throttle_thermal_policy
 Date:		Dec 2019
 KernelVersion:	5.6
@@ -102,4 +130,4 @@ Description:
 			* awake - 0 or 1, controls if the keyboard LED are on during awake
 			* sleep - 0 or 1, controls if a suspended animation is shown.
 						This is only active if the AC is connected.
-			* keyboard - 0 or 1, unknown what effect this really has
\ No newline at end of file
+			* keyboard - 0 or 1, unknown what effect this really has
-- 
2.37.1

On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones <luke@ljones.dev> wrote:
>
> Documents some previously added attributes:
> - dgpu_disable
> - egpu_enable
> - panel_od

Try to find a commit that introduced thouse and add the respective Fixes tag.

...

> -                       * keyboard - 0 or 1, unknown what effect this really has
> \ No newline at end of file
> +                       * keyboard - 0 or 1, unknown what effect this really has

Should be part of another patch.

-- 
With Best Regards,
Andy Shevchenko

Hi,

On 8/9/22 11:25, Andy Shevchenko wrote:
> On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones <luke@ljones.dev> wrote:
>>
>> Documents some previously added attributes:
>> - dgpu_disable
>> - egpu_enable
>> - panel_od
> 
> Try to find a commit that introduced thouse and add the respective Fixes tag.
> 
> ...
> 
>> -                       * keyboard - 0 or 1, unknown what effect this really has
>> \ No newline at end of file
>> +                       * keyboard - 0 or 1, unknown what effect this really has
> 
> Should be part of another patch.

Ack to both remarks.

Luke please make this patch one of the first patches in your next
version / patch-series and then add the doucmentation of the new
kbd RGB backlight attributes in the patches where you are also
adding those actual attributes.

Regards,

Hans

Hi,

On Thu, 2022-08-11 at 17:08 +0200, Hans de Goede wrote:
> Hi,
> 
> On 8/9/22 11:25, Andy Shevchenko wrote:
> > On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones <luke@ljones.dev>
> > wrote:
> > > 
> > > Documents some previously added attributes:
> > > - dgpu_disable
> > > - egpu_enable
> > > - panel_od
> > 
> > Try to find a commit that introduced thouse and add the respective
> > Fixes tag.
> > 
> > ...
> > 
> > > -                       * keyboard - 0 or 1, unknown what effect
> > > this really has
> > > \ No newline at end of file
> > > +                       * keyboard - 0 or 1, unknown what effect
> > > this really has
> > 
> > Should be part of another patch.
> 
> Ack to both remarks.
> 
> Luke please make this patch one of the first patches in your next
> version / patch-series and then add the doucmentation of the new
> kbd RGB backlight attributes in the patches where you are also
> adding those actual attributes.

Yep, done. Everything is looking much cleaner too.