[PATCH 0/3] sched/psi: psi bug fixes and cleanups

Hao Jia posted 3 patches 3 years, 8 months ago
include/linux/cgroup.h |  5 -----
include/linux/psi.h    |  2 +-
kernel/cgroup/cgroup.c |  2 +-
kernel/sched/psi.c     | 10 +++-------
4 files changed, 5 insertions(+), 14 deletions(-)
[PATCH 0/3] sched/psi: psi bug fixes and cleanups
Posted by Hao Jia 3 years, 8 months ago
These three patches are about PSI.
patch 1: Fixed PSI statistics error caused by unzeroed memory
in struct psi_group.
patch 2 and patch 3 are to clean up some unused functions
and parameters.

Hao Jia (3):
  sched/psi: Zero the memory of struct psi_group
  sched/psi: Remove unused parameter nbytes of psi_trigger_create()
  sched/psi: Remove redundant cgroup_psi() when !CONFIG_CGROUPS

 include/linux/cgroup.h |  5 -----
 include/linux/psi.h    |  2 +-
 kernel/cgroup/cgroup.c |  2 +-
 kernel/sched/psi.c     | 10 +++-------
 4 files changed, 5 insertions(+), 14 deletions(-)

-- 
2.32.0
Re: [PATCH 0/3] sched/psi: psi bug fixes and cleanups
Posted by Tejun Heo 3 years, 7 months ago
On Sat, Aug 06, 2022 at 08:05:07PM +0800, Hao Jia wrote:
> These three patches are about PSI.
> patch 1: Fixed PSI statistics error caused by unzeroed memory
> in struct psi_group.
> patch 2 and patch 3 are to clean up some unused functions
> and parameters.

Applied 1-3 to cgroup/for-6.0-fixes.

Thanks.

-- 
tejun
Re: [PATCH 0/3] sched/psi: psi bug fixes and cleanups
Posted by Tejun Heo 3 years, 8 months ago
(cc'ing Johannes)

On Sat, Aug 06, 2022 at 08:05:07PM +0800, Hao Jia wrote:
> These three patches are about PSI.
> patch 1: Fixed PSI statistics error caused by unzeroed memory
> in struct psi_group.
> patch 2 and patch 3 are to clean up some unused functions
> and parameters.
> 
> Hao Jia (3):
>   sched/psi: Zero the memory of struct psi_group
>   sched/psi: Remove unused parameter nbytes of psi_trigger_create()
>   sched/psi: Remove redundant cgroup_psi() when !CONFIG_CGROUPS
> 
>  include/linux/cgroup.h |  5 -----
>  include/linux/psi.h    |  2 +-
>  kernel/cgroup/cgroup.c |  2 +-
>  kernel/sched/psi.c     | 10 +++-------
>  4 files changed, 5 insertions(+), 14 deletions(-)

Johannes, care to review these patches?

Thanks.

-- 
tejun
Re: [PATCH 0/3] sched/psi: psi bug fixes and cleanups
Posted by Johannes Weiner 3 years, 8 months ago
On Tue, Aug 09, 2022 at 07:37:21AM -1000, Tejun Heo wrote:
> (cc'ing Johannes)
> 
> On Sat, Aug 06, 2022 at 08:05:07PM +0800, Hao Jia wrote:
> > These three patches are about PSI.
> > patch 1: Fixed PSI statistics error caused by unzeroed memory
> > in struct psi_group.
> > patch 2 and patch 3 are to clean up some unused functions
> > and parameters.
> > 
> > Hao Jia (3):
> >   sched/psi: Zero the memory of struct psi_group
> >   sched/psi: Remove unused parameter nbytes of psi_trigger_create()
> >   sched/psi: Remove redundant cgroup_psi() when !CONFIG_CGROUPS
> > 
> >  include/linux/cgroup.h |  5 -----
> >  include/linux/psi.h    |  2 +-
> >  kernel/cgroup/cgroup.c |  2 +-
> >  kernel/sched/psi.c     | 10 +++-------
> >  4 files changed, 5 insertions(+), 14 deletions(-)
> 
> Johannes, care to review these patches?

They look good to me.

Thanks!
Re: [PATCH 0/3] sched/psi: psi bug fixes and cleanups
Posted by Ingo Molnar 3 years, 8 months ago
* Hao Jia <jiahao.os@bytedance.com> wrote:

> These three patches are about PSI.
> patch 1: Fixed PSI statistics error caused by unzeroed memory
> in struct psi_group.
> patch 2 and patch 3 are to clean up some unused functions
> and parameters.
> 
> Hao Jia (3):
>   sched/psi: Zero the memory of struct psi_group
>   sched/psi: Remove unused parameter nbytes of psi_trigger_create()
>   sched/psi: Remove redundant cgroup_psi() when !CONFIG_CGROUPS
> 
>  include/linux/cgroup.h |  5 -----
>  include/linux/psi.h    |  2 +-
>  kernel/cgroup/cgroup.c |  2 +-
>  kernel/sched/psi.c     | 10 +++-------
>  4 files changed, 5 insertions(+), 14 deletions(-)

LGTM, and I suspect the scheduler fix wants to go upstream via the tree 
that introduced the bug, the cgroup tree?

For the series:

   Reviewed-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo