Add support for parallel port devices Netmos 9900 and Asix 99100

[PATCH 2/2] Add parport support for Asix device 99100

Posted by Alexander Baehr 3 years, 4 months ago

For some reason, Asix decided to produce a parallel port that is fully
compatible with Netmos device 9900, but named it 99100. It obviously has
another vendor ID, but the device ID is the same. This patch adds the 
required settings and was successfully tested with the Asix device. 

Signed-off-by: Alexander Baehr <abaehr@osadl.org>
---
 drivers/parport/parport_pc.c |    4 ++++
 include/linux/pci_ids.h      |    3 +++
 2 files changed, 7 insertions(+)

Index: linux/drivers/parport/parport_pc.c
===================================================================
--- linux.orig/drivers/parport/parport_pc.c
+++ linux/drivers/parport/parport_pc.c
@@ -2612,6 +2612,7 @@ enum parport_pc_pci_cards {
 	netmos_9815,
 	netmos_9901,
 	netmos_9865,
+	asix_ax99100,
 	quatech_sppxp100,
 	wch_ch382l,
 };
@@ -2766,6 +2767,9 @@ static const struct pci_device_id parpor
 	  0xA000, 0x1000, 0, 0, netmos_9865 },
 	{ PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9865,
 	  0xA000, 0x2000, 0, 0, netmos_9865 },
+	/* Asix AX99100 Parallel port PCIExpressCard */
+	{ PCI_VENDOR_ID_ASIX, PCI_DEVICE_ID_AX99100,
+	  0xA000, 0x2000, 0, 0, netmos_9900 },
 	/* Quatech SPPXP-100 Parallel port PCI ExpressCard */
 	{ PCI_VENDOR_ID_QUATECH, PCI_DEVICE_ID_QUATECH_SPPXP_100,
 	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, quatech_sppxp100 },
Index: linux/include/linux/pci_ids.h
===================================================================
--- linux.orig/include/linux/pci_ids.h
+++ linux/include/linux/pci_ids.h
@@ -3108,4 +3108,7 @@
 
 #define PCI_VENDOR_ID_NCUBE		0x10ff
 
+#define PCI_VENDOR_ID_ASIX		0x125b
+#define PCI_DEVICE_ID_AX99100		0x9100
+
 #endif /* _LINUX_PCI_IDS_H */

Re: [PATCH 2/2] Add parport support for Asix device 99100

Posted by Greg Kroah-Hartman 3 years, 3 months ago

On Sat, Aug 06, 2022 at 01:31:26PM +0200, Alexander Baehr wrote:
> For some reason, Asix decided to produce a parallel port that is fully
> compatible with Netmos device 9900, but named it 99100. It obviously has
> another vendor ID, but the device ID is the same. This patch adds the 
> required settings and was successfully tested with the Asix device. 
> 
> Signed-off-by: Alexander Baehr <abaehr@osadl.org>
> ---
>  drivers/parport/parport_pc.c |    4 ++++
>  include/linux/pci_ids.h      |    3 +++
>  2 files changed, 7 insertions(+)
> 
> Index: linux/drivers/parport/parport_pc.c
> ===================================================================
> --- linux.orig/drivers/parport/parport_pc.c
> +++ linux/drivers/parport/parport_pc.c
> @@ -2612,6 +2612,7 @@ enum parport_pc_pci_cards {
>  	netmos_9815,
>  	netmos_9901,
>  	netmos_9865,
> +	asix_ax99100,
>  	quatech_sppxp100,
>  	wch_ch382l,
>  };
> @@ -2766,6 +2767,9 @@ static const struct pci_device_id parpor
>  	  0xA000, 0x1000, 0, 0, netmos_9865 },
>  	{ PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9865,
>  	  0xA000, 0x2000, 0, 0, netmos_9865 },
> +	/* Asix AX99100 Parallel port PCIExpressCard */
> +	{ PCI_VENDOR_ID_ASIX, PCI_DEVICE_ID_AX99100,
> +	  0xA000, 0x2000, 0, 0, netmos_9900 },
>  	/* Quatech SPPXP-100 Parallel port PCI ExpressCard */
>  	{ PCI_VENDOR_ID_QUATECH, PCI_DEVICE_ID_QUATECH_SPPXP_100,
>  	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, quatech_sppxp100 },
> Index: linux/include/linux/pci_ids.h
> ===================================================================
> --- linux.orig/include/linux/pci_ids.h
> +++ linux/include/linux/pci_ids.h
> @@ -3108,4 +3108,7 @@
>  
>  #define PCI_VENDOR_ID_NCUBE		0x10ff
>  
> +#define PCI_VENDOR_ID_ASIX		0x125b
> +#define PCI_DEVICE_ID_AX99100		0x9100

Please read the top of this file for why to not add new ids to it.

thanks,

greg k-h

Re: [PATCH 2/2] Add parport support for Asix device 99100

Posted by Greg Kroah-Hartman 3 years, 4 months ago

On Sat, Aug 06, 2022 at 01:31:26PM +0200, Alexander Baehr wrote:
> For some reason, Asix decided to produce a parallel port that is fully
> compatible with Netmos device 9900, but named it 99100. It obviously has
> another vendor ID, but the device ID is the same. This patch adds the 
> required settings and was successfully tested with the Asix device. 
> 
> Signed-off-by: Alexander Baehr <abaehr@osadl.org>
> ---
>  drivers/parport/parport_pc.c |    4 ++++
>  include/linux/pci_ids.h      |    3 +++
>  2 files changed, 7 insertions(+)
> 
> Index: linux/drivers/parport/parport_pc.c
> ===================================================================
> --- linux.orig/drivers/parport/parport_pc.c
> +++ linux/drivers/parport/parport_pc.c
> @@ -2612,6 +2612,7 @@ enum parport_pc_pci_cards {
>  	netmos_9815,
>  	netmos_9901,
>  	netmos_9865,
> +	asix_ax99100,
>  	quatech_sppxp100,
>  	wch_ch382l,
>  };
> @@ -2766,6 +2767,9 @@ static const struct pci_device_id parpor
>  	  0xA000, 0x1000, 0, 0, netmos_9865 },
>  	{ PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9865,
>  	  0xA000, 0x2000, 0, 0, netmos_9865 },
> +	/* Asix AX99100 Parallel port PCIExpressCard */
> +	{ PCI_VENDOR_ID_ASIX, PCI_DEVICE_ID_AX99100,
> +	  0xA000, 0x2000, 0, 0, netmos_9900 },
>  	/* Quatech SPPXP-100 Parallel port PCI ExpressCard */
>  	{ PCI_VENDOR_ID_QUATECH, PCI_DEVICE_ID_QUATECH_SPPXP_100,
>  	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, quatech_sppxp100 },
> Index: linux/include/linux/pci_ids.h
> ===================================================================
> --- linux.orig/include/linux/pci_ids.h
> +++ linux/include/linux/pci_ids.h
> @@ -3108,4 +3108,7 @@
>  
>  #define PCI_VENDOR_ID_NCUBE		0x10ff
>  
> +#define PCI_VENDOR_ID_ASIX		0x125b
> +#define PCI_DEVICE_ID_AX99100		0x9100

Please read the top of this file for why we shouldn't be added new
entries to it.

thanks,

greg k-h