The variable mfiStatus is assigned a value but it is never read. The
assignment is redundant and can be removed. Also remove { } as the
return statement does not need to be in it's own code block.

Cleans up clang scan build warning:
drivers/scsi/megaraid/megaraid_sas_base.c:4026:7: warning: Although the
value stored to 'mfiStatus' is used in the enclosing expression, the
value is never actually read from 'mfiStatus' [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/scsi/megaraid/megaraid_sas_base.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index a3e117a4b8e7..c9b01b155f65 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -4023,10 +4023,8 @@ megasas_deplete_reply_queue(struct megasas_instance *instance,
 	u32 mfiStatus;
 	u32 fw_state;
 
-	if ((mfiStatus = instance->instancet->check_reset(instance,
-					instance->reg_set)) == 1) {
+	if (instance->instancet->check_reset(instance, instance->reg_set) == 1)
 		return IRQ_HANDLED;
-	}
 
 	mfiStatus = instance->instancet->clear_intr(instance);
 	if (mfiStatus == 0) {
-- 
2.35.3

On Fri, 5 Aug 2022 12:50:42 +0100, Colin Ian King wrote:

> The variable mfiStatus is assigned a value but it is never read. The
> assignment is redundant and can be removed. Also remove { } as the
> return statement does not need to be in it's own code block.
> 
> Cleans up clang scan build warning:
> drivers/scsi/megaraid/megaraid_sas_base.c:4026:7: warning: Although the
> value stored to 'mfiStatus' is used in the enclosing expression, the
> value is never actually read from 'mfiStatus' [deadcode.DeadStores]
> 
> [...]

Applied to 6.1/scsi-queue, thanks!

[1/1] scsi: megaraid: remove redundant assignment to variable mfiStatus
      https://git.kernel.org/mkp/scsi/c/4e62671a9a49

-- 
Martin K. Petersen	Oracle Linux Engineering

Colin,

> The variable mfiStatus is assigned a value but it is never read. The
> assignment is redundant and can be removed. Also remove { } as the
> return statement does not need to be in it's own code block.

Applied to 6.1/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering