From: Alexandre Bailon <abailon@baylibre.com>
This patch adds dt-binding documents for mt8192 and mt8195 thermal controllers.
Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
---
.../thermal/mediatek,lvts-thermal.yaml | 77 +++++++++++++++++++
1 file changed, 77 insertions(+)
create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
new file mode 100644
index 000000000000..53c44a73f3a4
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
@@ -0,0 +1,77 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek SoC LVTS thermal controller
+
+maintainers:
+ - Yu-Chia Chang <ethan.chang@mediatek.com>
+ - Ben Tseng <ben.tseng@mediatek.com>
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt8192-lvts-ap
+ - mediatek,mt8192-lvts-mcu
+ - mediatek,mt8195-lvts-ap
+ - mediatek,mt8195-lvts-mcu
+
+ "#thermal-sensor-cells":
+ const: 1
+
+ reg:
+ maxItems: 2
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ resets:
+ items:
+ - description: SW reset HW AP/MCU domain to clean temporary data on HW initialization/resume.
+
+ nvmem-cells:
+ items:
+ - description: LVTS calibration data 1 for thermal sensors
+ - description: LVTS calibration data 2 for thermal sensors
+
+ nvmem-cell-names:
+ items:
+ - const: lvts_calib_data1
+ - const: lvts_calib_data2
+
+required:
+ - compatible
+ - '#thermal-sensor-cells'
+ - reg
+ - interrupts
+ - clocks
+ - resets
+ - nvmem-cells
+ - nvmem-cell-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/thermal/thermal.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/mt8195-clk.h>
+ #include <dt-bindings/reset/mt8195-resets.h>
+
+ lvtsmcu: thermal-sensor@11278000 {
+ compatible = "mediatek,mt8195-lvts-mcu";
+ #thermal-sensor-cells = <1>;
+ reg = <0 0x11278000 0 0x400>;
+ interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH 0>;
+ clocks = <&infracfg_ao CLK_INFRA_AO_THERM>;
+ resets = <&infracfg_ao MT8195_INFRA_RST4_THERM_CTRL_MCU_SWRST>;
+ nvmem-cells = <&lvts_efuse_data1 &lvts_efuse_data2>;
+ nvmem-cell-names = "lvts_calib_data1", "lvts_calib_data2";
+ };
+
+...
--
2.34.1
On Thu, Aug 04, 2022 at 03:09:07PM +0200, bchihi@baylibre.com wrote: > From: Alexandre Bailon <abailon@baylibre.com> > > This patch adds dt-binding documents for mt8192 and mt8195 thermal controllers. > > Signed-off-by: Alexandre Bailon <abailon@baylibre.com> > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > --- > .../thermal/mediatek,lvts-thermal.yaml | 77 +++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > new file mode 100644 > index 000000000000..53c44a73f3a4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml [..] > + nvmem-cells: minItems: 1 since mt8192 only has one of them. > + items: > + - description: LVTS calibration data 1 for thermal sensors > + - description: LVTS calibration data 2 for thermal sensors > + > + nvmem-cell-names: Ditto. Thanks, Nícolas > + items: > + - const: lvts_calib_data1 > + - const: lvts_calib_data2 [..]
On 05/08/2022 01:11, Nícolas F. R. A. Prado wrote: >> diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml >> new file mode 100644 >> index 000000000000..53c44a73f3a4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > [..] >> + nvmem-cells: > > minItems: 1 > > since mt8192 only has one of them. Then add allOf:if:then: which will constrain it per variant/compatible. Best regards, Krzysztof
On Thu, 04 Aug 2022 15:09:07 +0200, bchihi@baylibre.com wrote: > From: Alexandre Bailon <abailon@baylibre.com> > > This patch adds dt-binding documents for mt8192 and mt8195 thermal controllers. > > Signed-off-by: Alexandre Bailon <abailon@baylibre.com> > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > --- > .../thermal/mediatek,lvts-thermal.yaml | 77 +++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dts:32.36-37 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:383: Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1404: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 04/08/2022 15:09, bchihi@baylibre.com wrote: > From: Alexandre Bailon <abailon@baylibre.com> > > This patch adds dt-binding documents for mt8192 and mt8195 thermal controllers. Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > Signed-off-by: Alexandre Bailon <abailon@baylibre.com> > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> Please rebase your patches on recent Linux kernel (or next). > --- > .../thermal/mediatek,lvts-thermal.yaml | 77 +++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > new file mode 100644 > index 000000000000..53c44a73f3a4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek SoC LVTS thermal controller > + > +maintainers: > + - Yu-Chia Chang <ethan.chang@mediatek.com> > + - Ben Tseng <ben.tseng@mediatek.com> > + Any reason why not referencing thermal-sensor.yaml? > +properties: > + compatible: > + enum: > + - mediatek,mt8192-lvts-ap > + - mediatek,mt8192-lvts-mcu > + - mediatek,mt8195-lvts-ap > + - mediatek,mt8195-lvts-mcu > + > + "#thermal-sensor-cells": > + const: 1 > + > + reg: > + maxItems: 2 You need to describe the items (like nvmem-cells). > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + resets: > + items: > + - description: SW reset HW AP/MCU domain to clean temporary data on HW initialization/resume. > + > + nvmem-cells: > + items: > + - description: LVTS calibration data 1 for thermal sensors > + - description: LVTS calibration data 2 for thermal sensors > + > + nvmem-cell-names: > + items: > + - const: lvts_calib_data1 > + - const: lvts_calib_data2 > + > +required: > + - compatible > + - '#thermal-sensor-cells' > + - reg > + - interrupts > + - clocks > + - resets > + - nvmem-cells > + - nvmem-cell-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/thermal/thermal.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/mt8195-clk.h> > + #include <dt-bindings/reset/mt8195-resets.h> > + > + lvtsmcu: thermal-sensor@11278000 { Mixed-up indentation. Best regards, Krzysztof
© 2016 - 2024 Red Hat, Inc.