[PATCH -next] perf stat: Remove duplicated include in builtin-stat.c

Yang Li posted 1 patch 3 years, 8 months ago
tools/perf/builtin-stat.c | 1 -
1 file changed, 1 deletion(-)
[PATCH -next] perf stat: Remove duplicated include in builtin-stat.c
Posted by Yang Li 3 years, 8 months ago
util/topdown.h is included twice in builtin-stat.c,
remove one of them.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1818
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 tools/perf/builtin-stat.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 3d22543fc305..e326226656e4 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -71,7 +71,6 @@
 #include "util/bpf_counter.h"
 #include "util/iostat.h"
 #include "util/pmu-hybrid.h"
- #include "util/topdown.h"
 #include "asm/bug.h"
 
 #include <linux/time64.h>
-- 
2.20.1.7.g153144c
Re: [PATCH -next] perf stat: Remove duplicated include in builtin-stat.c
Posted by Ian Rogers 3 years, 8 months ago
On Wed, Aug 3, 2022 at 5:52 PM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> util/topdown.h is included twice in builtin-stat.c,
> remove one of them.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1818
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Tested-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/builtin-stat.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index 3d22543fc305..e326226656e4 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -71,7 +71,6 @@
>  #include "util/bpf_counter.h"
>  #include "util/iostat.h"
>  #include "util/pmu-hybrid.h"
> - #include "util/topdown.h"
>  #include "asm/bug.h"
>
>  #include <linux/time64.h>
> --
> 2.20.1.7.g153144c
>
Re: [PATCH -next] perf stat: Remove duplicated include in builtin-stat.c
Posted by Arnaldo Carvalho de Melo 3 years, 8 months ago
Em Thu, Aug 04, 2022 at 08:32:22AM -0700, Ian Rogers escreveu:
> On Wed, Aug 3, 2022 at 5:52 PM Yang Li <yang.lee@linux.alibaba.com> wrote:
> >
> > util/topdown.h is included twice in builtin-stat.c,
> > remove one of them.
> >
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1818
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> 
> Tested-by: Ian Rogers <irogers@google.com>

Thanks, applied.

- Arnaldo

 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/builtin-stat.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> > index 3d22543fc305..e326226656e4 100644
> > --- a/tools/perf/builtin-stat.c
> > +++ b/tools/perf/builtin-stat.c
> > @@ -71,7 +71,6 @@
> >  #include "util/bpf_counter.h"
> >  #include "util/iostat.h"
> >  #include "util/pmu-hybrid.h"
> > - #include "util/topdown.h"
> >  #include "asm/bug.h"
> >
> >  #include <linux/time64.h>
> > --
> > 2.20.1.7.g153144c
> >

-- 

- Arnaldo