arm64: dts: qcom: sc8280xp: disallow regulator mode switches

[PATCH 0/3] arm64: dts: qcom: sc8280xp: disallow regulator mode switches

Posted by Johan Hovold 3 years, 8 months ago

A recent change in a USB/DP PHY driver that started specifying regulator
loads caused the regulators that were also shared with the PCIe and USB
PHYs to be put in low-power mode, something which broke PCIe and USB on
sa8295p-adp.

As was discussed in the following thread:

	https://lore.kernel.org/all/YtkrDcjTGhpaU1e0@hovoldconsulting.com

regulators should generally not be allowed to switch to low-power mode
unless some of the consumers can actually support an idle mode.

This series disables mode-switching for all regulators on sc8280xp-crd,
sc8280xp-lenovo-thinkpad-x13s and sa8295p-adp except for the ones used
by the UFS controllers which do support an idle mode.

Johan


Johan Hovold (3):
  arm64: dts: qcom: sc8280xp-crd: disallow regulator mode switches
  arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: disallow regulator
    mode switches
  arm64: dts: qcom: sa8295p-adp: disallow regulator mode switches

 arch/arm64/boot/dts/qcom/sa8295p-adp.dts              | 11 -----------
 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts             |  9 ---------
 .../boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts   | 10 ----------
 3 files changed, 30 deletions(-)

-- 
2.35.1

Re: [PATCH 0/3] arm64: dts: qcom: sc8280xp: disallow regulator mode switches

Posted by Bjorn Andersson 3 years, 7 months ago

On Wed, 3 Aug 2022 14:19:39 +0200, Johan Hovold wrote:
> A recent change in a USB/DP PHY driver that started specifying regulator
> loads caused the regulators that were also shared with the PCIe and USB
> PHYs to be put in low-power mode, something which broke PCIe and USB on
> sa8295p-adp.
> 
> As was discussed in the following thread:
> 
> [...]

Applied, thanks!

[1/3] arm64: dts: qcom: sc8280xp-crd: disallow regulator mode switches
      commit: 412737a60c846a6adb7f7571905c200da036815e
[2/3] arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: disallow regulator mode switches
      commit: 648ec2f2ddc05346287e308fbc31a6b8117a1edd
[3/3] arm64: dts: qcom: sa8295p-adp: disallow regulator mode switches
      commit: 2a6164cef63cae77edbd9deef844b1774886fcb7

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH 0/3] arm64: dts: qcom: sc8280xp: disallow regulator mode switches

Posted by Manivannan Sadhasivam 3 years, 8 months ago

On Wed, Aug 03, 2022 at 02:19:39PM +0200, Johan Hovold wrote:
> A recent change in a USB/DP PHY driver that started specifying regulator
> loads caused the regulators that were also shared with the PCIe and USB
> PHYs to be put in low-power mode, something which broke PCIe and USB on
> sa8295p-adp.
> 
> As was discussed in the following thread:
> 
> 	https://lore.kernel.org/all/YtkrDcjTGhpaU1e0@hovoldconsulting.com
> 
> regulators should generally not be allowed to switch to low-power mode
> unless some of the consumers can actually support an idle mode.
> 
> This series disables mode-switching for all regulators on sc8280xp-crd,
> sc8280xp-lenovo-thinkpad-x13s and sa8295p-adp except for the ones used
> by the UFS controllers which do support an idle mode.
> 

For the series,

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> Johan
> 
> 
> Johan Hovold (3):
>   arm64: dts: qcom: sc8280xp-crd: disallow regulator mode switches
>   arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: disallow regulator
>     mode switches
>   arm64: dts: qcom: sa8295p-adp: disallow regulator mode switches
> 
>  arch/arm64/boot/dts/qcom/sa8295p-adp.dts              | 11 -----------
>  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts             |  9 ---------
>  .../boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts   | 10 ----------
>  3 files changed, 30 deletions(-)
> 
> -- 
> 2.35.1
> 

-- 
மணிவண்ணன் சதாசிவம்