USB: apple-mfi-fastcharge:using the pm_runtime_resume_and_get to simplify the code

[PATCH linux-next] USB: apple-mfi-fastcharge:using the pm_runtime_resume_and_get to simplify the code

Posted by cgel.zte@gmail.com 3 years, 8 months ago

From: ye xingchen <ye.xingchen@zte.com.cn>

Using pm_runtime_resume_and_get() to instade of  pm_runtime_get_sync
and pm_runtime_put_noidle.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/usb/misc/apple-mfi-fastcharge.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/misc/apple-mfi-fastcharge.c b/drivers/usb/misc/apple-mfi-fastcharge.c
index ac8695195c13..1bf9a67f4cca 100644
--- a/drivers/usb/misc/apple-mfi-fastcharge.c
+++ b/drivers/usb/misc/apple-mfi-fastcharge.c
@@ -119,9 +119,8 @@ static int apple_mfi_fc_set_property(struct power_supply *psy,
 
 	dev_dbg(&mfi->udev->dev, "prop: %d\n", psp);
 
-	ret = pm_runtime_get_sync(&mfi->udev->dev);
+	ret = pm_runtime_resume_and_get(&mfi->udev->dev);
 	if (ret < 0) {
-		pm_runtime_put_noidle(&mfi->udev->dev);
 		return ret;
 	}
 
-- 
2.25.1

Re: [PATCH linux-next] USB: apple-mfi-fastcharge:using the pm_runtime_resume_and_get to simplify the code

Posted by Greg KH 3 years, 8 months ago

On Wed, Aug 03, 2022 at 06:14:52AM +0000, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Using pm_runtime_resume_and_get() to instade of  pm_runtime_get_sync
> and pm_runtime_put_noidle.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
>  drivers/usb/misc/apple-mfi-fastcharge.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/misc/apple-mfi-fastcharge.c b/drivers/usb/misc/apple-mfi-fastcharge.c
> index ac8695195c13..1bf9a67f4cca 100644
> --- a/drivers/usb/misc/apple-mfi-fastcharge.c
> +++ b/drivers/usb/misc/apple-mfi-fastcharge.c
> @@ -119,9 +119,8 @@ static int apple_mfi_fc_set_property(struct power_supply *psy,
>  
>  	dev_dbg(&mfi->udev->dev, "prop: %d\n", psp);
>  
> -	ret = pm_runtime_get_sync(&mfi->udev->dev);
> +	ret = pm_runtime_resume_and_get(&mfi->udev->dev);
>  	if (ret < 0) {
> -		pm_runtime_put_noidle(&mfi->udev->dev);
>  		return ret;
>  	}
>  
> -- 
> 2.25.1

For some reason you ignored my request in:
	https://lore.kernel.org/r/YujeLEMsIrVD2tGn@kroah.com 
so I'll just add your email to my discard list for a while, sorry.

greg k-h