[PATCH v2 net 2/4] vxlan: do not use RT_TOS for IPv6 flowlabel

Matthias May posted 4 patches 3 years, 8 months ago
There is a newer version of this series
[PATCH v2 net 2/4] vxlan: do not use RT_TOS for IPv6 flowlabel
Posted by Matthias May 3 years, 8 months ago
According to Guillaume Nault RT_TOS should never be used for IPv6.

Fixes: 1400615d64cf ("vxlan: allow setting ipv6 traffic class")
Signed-off-by: Matthias May <matthias.may@westermo.com>
---
v1 -> v2:
 - Fix spacing of "Fixes" tag.
 - Add missing CCs
---
 drivers/net/vxlan/vxlan_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index 265d4a0245e7..797585fbb004 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -2320,7 +2320,7 @@ static struct dst_entry *vxlan6_get_route(struct vxlan_dev *vxlan,
 	fl6.flowi6_oif = oif;
 	fl6.daddr = *daddr;
 	fl6.saddr = *saddr;
-	fl6.flowlabel = ip6_make_flowinfo(RT_TOS(tos), label);
+	fl6.flowlabel = ip6_make_flowinfo(tos, label);
 	fl6.flowi6_mark = skb->mark;
 	fl6.flowi6_proto = IPPROTO_UDP;
 	fl6.fl6_dport = dport;
-- 
2.35.1
Re: [PATCH v2 net 2/4] vxlan: do not use RT_TOS for IPv6 flowlabel
Posted by David Ahern 3 years, 8 months ago
On 8/2/22 6:09 AM, Matthias May wrote:
> According to Guillaume Nault RT_TOS should never be used for IPv6.
> 
> Fixes: 1400615d64cf ("vxlan: allow setting ipv6 traffic class")
> Signed-off-by: Matthias May <matthias.may@westermo.com>
> ---
> v1 -> v2:
>  - Fix spacing of "Fixes" tag.
>  - Add missing CCs
> ---
>  drivers/net/vxlan/vxlan_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>