[v1] Macb PTP enhancements

[PATCH 0/2] Macb PTP enhancements

Posted by Harini Katakam 3 years, 8 months ago

From: Harini Katakam <harini.katakam@amd.com>

This series is a follow up for patches 2 and 3 from a previous series:
https://lore.kernel.org/all/ca4c97c9-1117-a465-5202-e1bf276fe75b@microchip.com/
https://lore.kernel.org/all/20220517135525.GC3344@hoboy.vegasvil.org/
Sorry for the delay.

ACK is added only to patch 3 (now patch 2).
Patch 1 is updated with check for gem_has_ptp as per Claudiu's comments.

Harini Katakam (2):
  net: macb: Enable PTP unicast
  net: macb: Optimize reading HW timestamp

 drivers/net/ethernet/cadence/macb.h      |  4 ++++
 drivers/net/ethernet/cadence/macb_main.c | 13 ++++++++++++-
 drivers/net/ethernet/cadence/macb_ptp.c  |  8 ++++++--
 3 files changed, 22 insertions(+), 3 deletions(-)

-- 
2.17.1

Re: [PATCH 0/2] Macb PTP enhancements

Posted by Jakub Kicinski 3 years, 8 months ago

On Tue, 2 Aug 2022 16:13:44 +0530 Harini Katakam wrote:
> From: Harini Katakam <harini.katakam@amd.com>
> 
> This series is a follow up for patches 2 and 3 from a previous series:
> https://lore.kernel.org/all/ca4c97c9-1117-a465-5202-e1bf276fe75b@microchip.com/
> https://lore.kernel.org/all/20220517135525.GC3344@hoboy.vegasvil.org/
> Sorry for the delay.
> 
> ACK is added only to patch 3 (now patch 2).
> Patch 1 is updated with check for gem_has_ptp as per Claudiu's comments.

These were separated from the earlier series as non-fixes, right?
But we are in the period of merge window right now, when all the
new features flow to Linus's tree and we only take fixes to avoid
conflicts and give maintainers time to settle the existing ones.
So these need to wait until -rc1 is cut. (Or is patch 1 a bug fix? 
I can't tell.)

RE: [PATCH 0/2] Macb PTP enhancements

Posted by Katakam, Harini 3 years, 8 months ago

Hi Jakub,

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Thursday, August 4, 2022 8:05 AM
> To: Harini Katakam <harini.katakam@xilinx.com>
> Cc: nicolas.ferre@microchip.com; davem@davemloft.net;
> richardcochran@gmail.com; claudiu.beznea@microchip.com;
> andrei.pistirica@microchip.com; edumazet@google.com;
> pabeni@redhat.com; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; michal.simek@xilinx.com;
> harinikatakamlinux@gmail.com; Simek, Michal <michal.simek@amd.com>;
> Katakam, Harini <harini.katakam@amd.com>; Pandey, Radhey Shyam
> <radhey.shyam.pandey@amd.com>
> Subject: Re: [PATCH 0/2] Macb PTP enhancements
> 
> On Tue, 2 Aug 2022 16:13:44 +0530 Harini Katakam wrote:
> > From: Harini Katakam <harini.katakam@amd.com>
> >
> > This series is a follow up for patches 2 and 3 from a previous series:
> > https://lore.kernel.org/all/ca4c97c9-1117-a465-5202-e1bf276fe75b@micro
> > chip.com/
> > https://lore.kernel.org/all/20220517135525.GC3344@hoboy.vegasvil.org/
> > Sorry for the delay.
> >
> > ACK is added only to patch 3 (now patch 2).
> > Patch 1 is updated with check for gem_has_ptp as per Claudiu's comments.
> 
> These were separated from the earlier series as non-fixes, right?
> But we are in the period of merge window right now, when all the new
> features flow to Linus's tree and we only take fixes to avoid conflicts and give
> maintainers time to settle the existing ones.
> So these need to wait until -rc1 is cut. (Or is patch 1 a bug fix?
> I can't tell.)

Sorry, I missed the window. Yes, both are non-fixes and I'll resend after the
Tree is open.

Regards,
Harini