[PATCH linux-next] staging: greybus:using the pm_runtime_resume_and_get to simplify the code

cgel.zte@gmail.com posted 1 patch 3 years, 8 months ago
drivers/greybus/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH linux-next] staging: greybus:using the pm_runtime_resume_and_get to simplify the code
Posted by cgel.zte@gmail.com 3 years, 8 months ago
From: ye xingchen <ye.xingchen@zte.com.cn>

Using pm_runtime_resume_and_get() to instade of  pm_runtime_get_sync
and pm_runtime_put_noidle.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
 drivers/greybus/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/greybus/core.c b/drivers/greybus/core.c
index e546c6431877..b9063e86534b 100644
--- a/drivers/greybus/core.c
+++ b/drivers/greybus/core.c
@@ -174,9 +174,8 @@ static int greybus_probe(struct device *dev)
 	if (!id)
 		return -ENODEV;
 
-	retval = pm_runtime_get_sync(&bundle->intf->dev);
+	retval = pm_runtime_resume_and_get(&bundle->intf->dev);
 	if (retval < 0) {
-		pm_runtime_put_noidle(&bundle->intf->dev);
 		return retval;
 	}
 
-- 
2.25.1
Re: [PATCH linux-next] staging: greybus:using the pm_runtime_resume_and_get to simplify the code
Posted by Greg KH 3 years, 8 months ago
On Tue, Aug 02, 2022 at 07:45:42AM +0000, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Using pm_runtime_resume_and_get() to instade of  pm_runtime_get_sync
> and pm_runtime_put_noidle.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>

Please follow the rules in
Documentation/process/researcher-guidelines.rst for stuff like this,
otherwise I have to reject it.

greg k-h