[PATCH 5.10 0/3] fix build error in bpf selftests

Tianchen Ding posted 3 patches 3 years, 8 months ago
include/linux/bpf.h                           |  10 +
include/uapi/linux/bpf.h                      |   5 +-
net/bpf/test_run.c                            | 243 +++++++++++++-----
net/core/filter.c                             |   1 +
tools/include/uapi/linux/bpf.h                |   5 +-
tools/testing/selftests/bpf/test_verifier.c   |   4 +-
.../selftests/bpf/verifier/ctx_sk_lookup.c    |   1 +
7 files changed, 204 insertions(+), 65 deletions(-)
[PATCH 5.10 0/3] fix build error in bpf selftests
Posted by Tianchen Ding 3 years, 8 months ago
We found a compile error when building tools/testing/selftests/bpf/ on 5.10.y.
tools/testing/selftests/bpf/prog_tests/sk_lookup.c:1092:15: error: 'struct bpf_sk_lookup' has no member named 'cookie'
 1092 |  if (CHECK(ctx.cookie == 0, "ctx.cookie", "no socket selected\n"))
      |               ^

To fix this bug, this patchset backports three patches from upstream:
https://lore.kernel.org/bpf/20210303101816.36774-1-lmb@cloudflare.com/

Patch 1 and 2 are necessary for bpf selftests build pass on 5.10.y.
Patch 3 does not impact building stage, but can avoid a test case
failure (by skipping it).

Lorenz Bauer (3):
  bpf: Consolidate shared test timing code
  bpf: Add PROG_TEST_RUN support for sk_lookup programs
  selftests: bpf: Don't run sk_lookup in verifier tests

 include/linux/bpf.h                           |  10 +
 include/uapi/linux/bpf.h                      |   5 +-
 net/bpf/test_run.c                            | 243 +++++++++++++-----
 net/core/filter.c                             |   1 +
 tools/include/uapi/linux/bpf.h                |   5 +-
 tools/testing/selftests/bpf/test_verifier.c   |   4 +-
 .../selftests/bpf/verifier/ctx_sk_lookup.c    |   1 +
 7 files changed, 204 insertions(+), 65 deletions(-)

-- 
2.27.0
Re: [PATCH 5.10 0/3] fix build error in bpf selftests
Posted by Greg Kroah-Hartman 3 years, 8 months ago
On Mon, Aug 01, 2022 at 03:29:13PM +0800, Tianchen Ding wrote:
> We found a compile error when building tools/testing/selftests/bpf/ on 5.10.y.
> tools/testing/selftests/bpf/prog_tests/sk_lookup.c:1092:15: error: 'struct bpf_sk_lookup' has no member named 'cookie'
>  1092 |  if (CHECK(ctx.cookie == 0, "ctx.cookie", "no socket selected\n"))
>       |               ^
> 
> To fix this bug, this patchset backports three patches from upstream:
> https://lore.kernel.org/bpf/20210303101816.36774-1-lmb@cloudflare.com/
> 
> Patch 1 and 2 are necessary for bpf selftests build pass on 5.10.y.
> Patch 3 does not impact building stage, but can avoid a test case
> failure (by skipping it).

Now queued up, thanks.

greg k-h