[v1] soc: sunxi: sram: Fixes and D1 support

[PATCH 5/9] soc: sunxi: sram: Fix debugfs info for A64 SRAM C

Posted by Samuel Holland 3 years, 8 months ago

The labels were backward with respect to the register values. The SRAM
is mapped to the CPU when the register value is 1.

Fixes: 5e4fb6429761 ("drivers: soc: sunxi: add support for A64 and its SRAM C")
Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 drivers/soc/sunxi/sunxi_sram.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c
index 52d07bed7664..09754cd1d57d 100644
--- a/drivers/soc/sunxi/sunxi_sram.c
+++ b/drivers/soc/sunxi/sunxi_sram.c
@@ -78,8 +78,8 @@ static struct sunxi_sram_desc sun4i_a10_sram_d = {
 
 static struct sunxi_sram_desc sun50i_a64_sram_c = {
 	.data	= SUNXI_SRAM_DATA("C", 0x4, 24, 1,
-				  SUNXI_SRAM_MAP(0, 1, "cpu"),
-				  SUNXI_SRAM_MAP(1, 0, "de2")),
+				  SUNXI_SRAM_MAP(1, 0, "cpu"),
+				  SUNXI_SRAM_MAP(0, 1, "de2")),
 };
 
 static const struct of_device_id sunxi_sram_dt_ids[] = {
-- 
2.35.1

Re: [PATCH 5/9] soc: sunxi: sram: Fix debugfs info for A64 SRAM C

Posted by Jernej Škrabec 3 years, 8 months ago

Dne ponedeljek, 01. avgust 2022 ob 05:05:05 CEST je Samuel Holland napisal(a):
> The labels were backward with respect to the register values. The SRAM
> is mapped to the CPU when the register value is 1.
> 
> Fixes: 5e4fb6429761 ("drivers: soc: sunxi: add support for A64 and its SRAM
> C") 
> Signed-off-by: Samuel Holland <samuel@sholland.org>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej