[PATCH] arm64: dts: juno: Add missing MHU secure-irq

jassisinghbrar@gmail.com posted 1 patch 3 years, 8 months ago
There is a newer version of this series
arch/arm64/boot/dts/arm/juno-base.dtsi | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
[PATCH] arm64: dts: juno: Add missing MHU secure-irq
Posted by jassisinghbrar@gmail.com 3 years, 8 months ago
From: Jassi Brar <jaswinder.singh@linaro.org>

The MHU secure interrupt exists physically but is missing in the DT node.

Specify the interrupt in DT node to fix a warning on Arm Juno board:
   mhu@2b1f0000: interrupts: [[0, 36, 4], [0, 35, 4]] is too short

Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
---
 arch/arm64/boot/dts/arm/juno-base.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
index f6c55877fbd94..3220a00e9500d 100644
--- a/arch/arm64/boot/dts/arm/juno-base.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
@@ -26,9 +26,11 @@ mailbox: mhu@2b1f0000 {
 		compatible = "arm,mhu", "arm,primecell";
 		reg = <0x0 0x2b1f0000 0x0 0x1000>;
 		interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
-			     <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
+			     <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-names = "mhu_lpri_rx",
-				  "mhu_hpri_rx";
+				  "mhu_hpri_rx",
+				  "mhu_secure_rx";
 		#mbox-cells = <1>;
 		clocks = <&soc_refclk100mhz>;
 		clock-names = "apb_pclk";
-- 
2.25.1
Re: [PATCH] arm64: dts: juno: Add missing MHU secure-irq
Posted by Sudeep Holla 3 years, 8 months ago
On Sat, Jul 30, 2022 at 09:23:36AM -0500, jassisinghbrar@gmail.com wrote:
> From: Jassi Brar <jaswinder.singh@linaro.org>
> 
> The MHU secure interrupt exists physically but is missing in the DT node.
> 
> Specify the interrupt in DT node to fix a warning on Arm Juno board:
>    mhu@2b1f0000: interrupts: [[0, 36, 4], [0, 35, 4]] is too short
>

It fails to apply on v5.18-rc1 or v5.19. Can you please rebase and resend ?

-- 
Regards,
Sudeep
Re: [PATCH] arm64: dts: juno: Add missing MHU secure-irq
Posted by Sudeep Holla 3 years, 8 months ago
On Mon, Aug 01, 2022 at 11:33:08AM +0100, Sudeep Holla wrote:
> On Sat, Jul 30, 2022 at 09:23:36AM -0500, jassisinghbrar@gmail.com wrote:
> > From: Jassi Brar <jaswinder.singh@linaro.org>
> > 
> > The MHU secure interrupt exists physically but is missing in the DT node.
> > 
> > Specify the interrupt in DT node to fix a warning on Arm Juno board:
> >    mhu@2b1f0000: interrupts: [[0, 36, 4], [0, 35, 4]] is too short
> >
> 
> It fails to apply on v5.18-rc1 or v5.19. Can you please rebase and resend ?
> 

Sorry I meant v5.19-rc1 or v5.19 as my -next branch is based on the former.
IIUC the interrupt-names are dropped couple of release back as it was not
in the binding.

-- 
Regards,
Sudeep