audit: Modifying indentation issue.

[PATCH] audit: Modifying indentation issue.

Posted by l00581214 3 years, 8 months ago

From: Tie Liu <liutie4@huawei.com>

Modifying indentation issue in audit_rate_check().

Signed-off-by: Tie Liu <liutie4@huawei.com>
---
 kernel/audit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/audit.c b/kernel/audit.c
index 7690c29d4..deeede166 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -324,7 +324,8 @@ static inline int audit_rate_check(void)
 	unsigned long		elapsed;
 	int			retval	   = 0;
 
-	if (!audit_rate_limit) return 1;
+	if (!audit_rate_limit)
+		return 1;
 
 	spin_lock_irqsave(&lock, flags);
 	if (++messages < audit_rate_limit) {
-- 
2.27.0

Re: [PATCH] audit: Modifying indentation issue.

Posted by Paul Moore 3 years, 7 months ago

On Fri, Jul 29, 2022 at 5:05 AM l00581214 <liutie4@huawei.com> wrote:
>
> From: Tie Liu <liutie4@huawei.com>
>
> Modifying indentation issue in audit_rate_check().
>
> Signed-off-by: Tie Liu <liutie4@huawei.com>
> ---
>  kernel/audit.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

While I agree that the style in this patch is preferable to the
existing style in the code, I'm growing weary of these minor style
change from developers who have not contributing any other meaningful
change to the audit subsystem.  Once you have established a history of
useful contributions to the audit subsystem feel free to (re)submit
this patch.

> diff --git a/kernel/audit.c b/kernel/audit.c
> index 7690c29d4..deeede166 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -324,7 +324,8 @@ static inline int audit_rate_check(void)
>         unsigned long           elapsed;
>         int                     retval     = 0;
>
> -       if (!audit_rate_limit) return 1;
> +       if (!audit_rate_limit)
> +               return 1;
>
>         spin_lock_irqsave(&lock, flags);
>         if (++messages < audit_rate_limit) {

-- 
paul-moore.com